Hi Everyone,
I want to bring this PR to your attention:
https://github.com/apache/nuttx/pull/18840

I have some concerns like those added to my Change Request there.

I think broad modifications like this need to be discussed with our
community.

I'm not against this PR, it will avoid the 2038 Unix Epoch BUG, but it is
important to know first the impact of this commit to small microcontrollers.

Unfortunately we don't have how many bytes this PR will add/remove to/from
Flash and RAM.

Also we discussed many times that all PRs need to include valid testing,
just "checkpatch.sh -f" is not a real test, it doesn't guarantee that the
PR will pass in the CI.

In cases like this where a PR modifies many boards and MCUs, a good idea it
to test it on your own github account first, before submitting the PR, as
explained here: https://github.com/apache/nuttx/issues/18568

This is not a criticism of the author, that is my friend, but it is
important that we improve our process. Seems like we are still messing with
basic things.

BR,

Alan

Reply via email to