[ https://issues.apache.org/jira/browse/ODE-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730576#action_12730576 ]
Alex Boisvert commented on ODE-635: ----------------------------------- The JBI spec is not very good at clarifying what the behavior should be... It says among other things, A failed deployment of the service unit must be reported using the component-task-result element as well; the task-result must be set to FAILED. (page 131) but also says that the deploy() method, Throws: javax.jbi.management.DeploymentException141 - if the deployment operation is unsuccessful. (page 132) As well as, Components supply status/result strings as XML strings that conform to the component-task-result-details type from the above schema. For example, the ServiceUnitManager.deploy() method returns such a status/ result string. The JBI implementation MUST combine the status/result strings supplied by components into the the overall status/result document defined above. (page 86) So it's difficult to determine which behavior is correct... > Propagate DeploymentException when SA deployment fails. > ------------------------------------------------------- > > Key: ODE-635 > URL: https://issues.apache.org/jira/browse/ODE-635 > Project: ODE > Issue Type: Improvement > Components: JBI Integration > Affects Versions: 1.3.2, 1.3.3, 2.0 > Environment: ServiceMix 4 > Reporter: Daniel Dominguez > Attachments: ODE-635.patch > > > I'm working on deployment tooling for ServiceMix4 / FUSE. The deploy and > undeploy method in OdeSUManager does not throw a DeploymentException when > there is a problem with a service assembly (i.e. bad deploy.xml). In > contrast the start and stop methods both throw DeploymentException when > appropriate. > The problem this causes for me is that when I attempt to deploy and start a > service assembly, the deploy appears to succeed but the start returns an > unrelated error which is difficult to diagnose. > I've created a simple patch which will throw the DeploymentException instead > of an error string which is ignored by smx4. > Is this a reasonable approach? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.