[
https://issues.apache.org/jira/browse/OFBIZ-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464290
]
Jacques Le Roux commented on OFBIZ-270:
---------------------------------------
Daniel,
I agree with Crhis and reviewed your patch, sounds rather fine to me (did not
dive in details).
One question though : your patch is modifying UtilHttp.java (now in framework/
but that's not the problem)
Index: base/src/base/org/ofbiz/base/util/UtilHttp.java
===================================================================
--- base/src/base/org/ofbiz/base/util/UtilHttp.java (revision 6470)
+++ base/src/base/org/ofbiz/base/util/UtilHttp.java (working copy)
@@ -461,7 +461,7 @@
}
if (valueStr != null && valueStr.length() > 0) {
- if (buf.length() > 0) buf.append("&");
+ if (buf.length() > 0) buf.append("&"); //
("&"); dlk - Test
try {
buf.append(URLEncoder.encode(name, "UTF-8"));
} catch (UnsupportedEncodingException e) {
Are you sure that that's needed ? I ask because of << // ("&"); dlk -
Test >>
Thanks
> USPS Rate Estimation
> --------------------
>
> Key: OFBIZ-270
> URL: https://issues.apache.org/jira/browse/OFBIZ-270
> Project: Apache OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: product
> Affects Versions: SVN trunk
> Environment: Any
> Reporter: Marco Risaliti
> Assigned To: Jacques Le Roux
> Priority: Minor
> Attachments: shipping.patch
>
>
> This is a copy of the old Jira issue
> http://jira.undersunconsulting.com/browse/OFBIZ-657 from Daniel Kunkel
> ===========================================================
> The USPS automatic Rate Inquiry module has numerous flaws.
> I was able to find and fix them, albeit, with potentially unacceptable
> techniques.
> Specifically:
> 1.) USPS now uses Get and does not Post any longer.
> 2.) Pounds must be a integer number.
> 3.) The calculation for breaking a weight into pounds and ounces was
> inaccurate. (UPS module too)
> 4.) The HttpClient HTTP GET was inserting & between the value pairs
> instead of &
> !!!! My fix for this issue may not be appropriate!
> 5.) No provision for converting other units of measure to Pounds. Other parts
> of the program seem to default to the ounce, while shipping defaulted to the
> pound.
> Remaining Issues...
> Must find a way to disable the estimator during an error. The system
> currently defaults to $1, which is a believeable, yet money loosing postage.
> Need to add International Shipping Support.
> Finally... This is my first patch contribution... It will need extra time and
> attention to verify!
> Thanks
> Daniel
>
>
> All Comments Work Log Change History Sort Order:
> Comment by Daniel Kunkel [08/Jan/06 02:13 AM] [ Permlink ]
> My fixes which SEEM to work. Your milage may vary.
> Comment by Marco Risaliti [13/Sep/06 01:43 AM] [ Permlink ]
> Can be closed ?
> Thanks
> Marco
> Comment by Daniel Kunkel [13/Sep/06 02:09 AM] [ Permlink ]
> I think it would be a waste to close this issue without first applying the
> patch... Granted it was my first patch and even I don't like the code, but it
> did get the domestic USPS postal calculator working which has been a real
> boon for our business. Furthermore it allowed for the conversion of product
> weights to lbs for the usps, another feature we needed.
> PS. I do have an iCLA signed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
