[ 
https://issues.apache.org/jira/browse/OFBIZ-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464508
 ] 

Jacques Le Roux commented on OFBIZ-516:
---------------------------------------

Fred,

I retried your patch. Just a quick remark before commenting it : your last 
patch (showcart_patch.txt) is wrapped at column 42. Please check this, even if 
for a short patch like this one it's ok.

1. The cart problem is solved
2. "ecommerce link in the orderview order items"  and "recenlty ordered items 
box on the bottom left" (I guess you mean "Quick reorder" box) : you are right 
still problems there and I guess your suggestion is the right one as you 
already applied it in your patch (passing parentProductId).
3. There is the same problem than "ecommerce link in the orderview order items" 
 from order view accessed from history by user.

I looked at your code about survey and it seems OK, but I was not able to test 
it because I'm not sure of what you mean by "selection of surveys for an add to 
cart survey" (and I have no more time to dig in code to understand ;o)

So I commited your patch in a CTR mode in revision 495945  and keep this issue 
open ...


> virtual products sharing variants can cause inconsistest shopping cart
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-516
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-516
>             Project: Apache OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment: linux
>            Reporter: Fred Forester
>         Assigned To: Jacques Le Roux
>            Priority: Minor
>         Attachments: Sans titre.PNG, showcart_patch.txt, variant_patch.log
>
>
> If Virtual products are set up to share a group of variants the shopping cart 
> may show a different virtual product than the one the customer actually 
> selected.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to