Jacques,
I think it's fine to put these in for now, especially if you've already gone through the bulk of the work. That at least leaves less files to worry about later.
As for the ModelInfo and DatabaseUtil files, manual changes are fine. Note that they are probably failing because of some default meta-data that includes copyright strings, and those can probably stay just fine for now.
-David On Jan 16, 2007, at 8:18 AM, Jacques Le Roux wrote:
David & all,I checked the result of work done by Eclipse "Advanced fix copyrights" option in Navigator and it turned just great but for *javaand properties files* only.It generates a copyrightLog.txt file in workspace root directory (it may work on many projects at a time). In this file I found thatonly 2 files were not modified to new ASL2 licence. It says Multiple copyrights found. File UNCHANGED. ModelInfo.java DatabaseUtil.javaI checked this files and actually there a some copyright infos generated in. It seems that ModelInfo.java body has to be updated, licence may be updated by hand. Same for DatabaseUtil.java but simpler.I changed this 2 files by hand. Now I'm asking myself : should I commit this changes (java an properties only) or do you prefer thatwe test perl batches before ?This tool was used by Eclipse project when they changed licence from 2.1 o 3.1.Jacques ----- Original Message ----- From: "Jacques Le Roux" <[EMAIL PROTECTED]> To: <dev@ofbiz.apache.org> Sent: Tuesday, January 16, 2007 3:10 PM Subject: Re: Copyright StatementEclipse "Fix copyright" option workss well but only on java and properties files. I will revert and try the batch now.Jacques From: "Jacques Le Roux" <[EMAIL PROTECTED]>David, From: "David E. Jones" <[EMAIL PROTECTED]>On Jan 15, 2007, at 8:41 PM, Chris Howe wrote:Thanks J Aaron! David, as per that link, should we make a JIRA issue to remove the copyright notice from the source headers?Interesting... it looks like that page has changed since our pre- graduation review was done a few months ago. And yes, according to the new information we need to get this done before we do the release branch.It looks like there are some scripts created for this that can help out.Any volunteers to give this a try?I will take a look at this this afternoon (it's 14h00 here). I will also look into Eclipse Licence option (contextual menu innavigator). JacquesThanks, -David
smime.p7s
Description: S/MIME cryptographic signature