Maybe, as a compromise, to avoid the properties file issue you could just put an extra field in the UI for the character(s) to use to separate the base ID from the feature idCode(s).
-David On Jan 20, 2007, at 12:04 AM, Jonathon -- Improov wrote:
Si,> This patch is a good idea, but I think Scott Gray suggested that this > "-" could be configured in a properties file, and I think that's a good> idea. Otherwise, if you have four or five features you will easily> overrun the 20-character productId key limit. Keeping it in properties > file is a good way to allow it to be modified. Otherwise it's not very> nice to have to go into the code to do it.David said it's ok to hardcode it for now. I was arguing, but of course it struck me that it wouldn't be difficult to "customization" the hardcoding it folks needed to place say '--' or '*' instead of '-'.I was of the idea that we put a field on the QuickAddVariants page to allow users to specify the separator ('-' or '*' or 'whatever').I was thinking we have '-' as the default. Then we allow config properties to override this default.> Jonathon, you up for doing this and sending in another patch? Ok, sure. Which config file and what config param name you want it in? Jonathon Si Chen wrote:Hey there -This patch is a good idea, but I think Scott Gray suggested that this "-" could be configured in a properties file, and I think that's a good idea. Otherwise, if you have four or five features you will easily overrun the 20-character productId key limit. Keeping it in properties file is a good way to allow it to be modified. Otherwise it's not very nice to have to go into the code to do it.Jonathon, you up for doing this and sending in another patch? Si--------------------------------------------------------------------- ---No virus found in this incoming message. Checked by AVG Free Edition.Version: 7.5.432 / Virus Database: 268.17.0/639 - Release Date: 1/18/2007 6:47 PM
smime.p7s
Description: S/MIME cryptographic signature
