Since this is already in and there are certainly tons of other examples of this - it really doesn't matter, but I just wanted to call attention to something that stuck out to me.

We should do our best not to embed any style attributes into the code as we're in there - as well as doing our best to give classes or ids to divs so that they can be styled more easily in the future.

Thanks for fixing the bug nonetheless, Jonathon.

Cheers,
Tim
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595


On Jan 28, 2007, at 9:14 PM, Scott Gray (JIRA) wrote:


[ https://issues.apache.org/jira/browse/OFBIZ-622? page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-622.
----------------------------

    Resolution: Fixed

Thanks Jonathon, your patch is in with rev. 500936

A long selectAllForm's table will overlap with addVariantsToVirtual's table --------------------------------------------------------------------- ------

                Key: OFBIZ-622
                URL: https://issues.apache.org/jira/browse/OFBIZ-622
            Project: OFBiz (The Open for Business Project)
         Issue Type: Bug
         Components: product
   Affects Versions: SVN trunk
        Environment: Firefox 2.0.0.1
           Reporter: Jonathon Wong
        Assigned To: Scott Gray
            Fix For: SVN trunk

        Attachments: QuickAddVariants.ftl.patch


Bug in file QuickAddVariants.ftl.
I switched the position of the <div> containing the addVariantsToVirtual form to below the selectAllForm form. I also put the selectAllForm form into a <div style="float: left">. So there are now 2 <div>s instead 1: the 1st <div> floats left and contains the selectAllForm, the 2nd <div> floats right as usual and contains the addVariantsToVirtual form. This way, if the selectAllForm is not too wide, both forms sit side by side as usual. Otherwise, the addVariantsToVirtual form gets bumped down the page.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to