[ 
https://issues.apache.org/jira/browse/OFBIZ-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469588
 ] 

Si Chen commented on OFBIZ-682:
-------------------------------

I think there's a good case to be made for leaving the flexibility of more than 
one billing account per order or invoice.  It would be nice at some point to 
allow multiple billing accounts or store credits on the same account.  I don't 
see a reason why it should be one and only one billing account.

Also, the problem I'm having is with one billing account and a credit card.

In the meantime, the highlighted code is *definitely* causing a bug, and I'd 
like to remove it until you have something else.

> Possibly dangerous code in createPaymentApplication for billingAccount
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-682
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-682
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Si Chen
>
> This code is back in createPaymentApplication and could be potentially 
> dangerous:
>             <if-not-empty field-name="invoice.billingAccountId">
>                 <set field="paymentAppl.billingAccountId" 
> from-field="invoice.billingAccountId"/>
>             </if-not-empty> 
> there could be problems with balance calculations when billing accounts and 
> other methods are used to pay for orders.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to