[ 
https://issues.apache.org/jira/browse/OFBIZ-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470100
 ] 

David E. Jones commented on OFBIZ-644:
--------------------------------------

In general I don't like the pattern used in this patch. It doesn't follow best 
practices or use the tools and patterns established in OFBiz to make all of our 
lives easier, during implementation but even more importantly during 
maintenance and customization. There are very good reasons we recommend using 
object oriented patterns written in Java on only very rare occasions. This is a 
good example of something that is not complex enough to justify, and it will be 
a maintenance problem in the future.

There is one place where it crosses a line that I'm really not okay with. If we 
added properties files for every little thing like this we would have hundreds 
of them lying around, a nightmare to navigate, use, and maintain. So, that is 
going away in a few minutes.


> Pagination in https://host_name:8443/ordermgr/control/orderlist needed
> ----------------------------------------------------------------------
>
>                 Key: OFBIZ-644
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-644
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: order
>    Affects Versions: SVN trunk
>         Environment: All
>            Reporter: Walter Vaughan
>         Assigned To: Jacques Le Roux
>             Fix For: SVN trunk
>
>         Attachments: orderliststate-svn.patch, orderliststate.patch
>
>
> There is no pagination in https://host_name:8443/ordermgr/control/orderlist. 
> If a status like "sent' is chosen, thousands or millions of rows will be 
> returned if there is that many in the database. Some sort of pagination 
> system like we have in https://host_name:8443/partymgr/control/findparty with 
> some sort of higher limit like 100 records or so might be good, as to not 
> break behavior for most existing users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to