[ 
https://issues.apache.org/jira/browse/OFBIZ-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472861
 ] 

Si Chen commented on OFBIZ-309:
-------------------------------

We just looked through this and it appears that we need to make that change to 
ModelServiceReader from true to false to preserve the optional flag from the 
interface.

I think this is the right way to do it.  If there are no objections, i'd like 
to commit Leon's patch from above.

> If a service is implemented as an interface, its settings for optional 
> attributes are ignored!
> ----------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-309
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-309
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Leon Torres
>         Assigned To: Si Chen
>            Priority: Critical
>         Attachments: services.patch
>
>
> This is bad:
> If a service has some attributes with optional="false" and is implemented 
> with <implements service="">, the settings for optional are ignored and 
> default to "true" instead.
> As an example, look up the service definition for  upsRateEstimate  in 
> webtools and compare to the service that it implements, 
> calcShipmentEstimateInterface.  The interface defines a few optional fields 
> as false, which show up correctly for calcShipmentEstimateInterface but are 
> all set to true in upsRateEstimate.
> It used to work, something must have broken it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to