[
https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475639
]
Adrian Crum commented on OFBIZ-671:
-----------------------------------
Jacopo,
Thank you for taking a look at this!
I will work on using the appendWhitespace method. I was trying to keep things
concise, but I understand your point.
I added the spaces and commented out some of the appendWhitespace method calls
so that the markup the widget generates is more readable. It was my plan to
change those back after the refactor.
I will take another look at the new attributes. It appeared to me that there
was no way to assign an id or a style to the <form> element - that's why I
included them. I will change the name of focus-widget, your suggestion sounds
better.
> Remove HTML styling code from widgets
> -------------------------------------
>
> Key: OFBIZ-671
> URL: https://issues.apache.org/jira/browse/OFBIZ-671
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: formwidget.patch, menuwidget.patch, menuwidget.patch,
> treewidget.patch
>
>
> Widgets have embedded styling code in them. Styling should be left to the css
> files. A CSS class should be created called "alert" or something similar, and
> that class should be used instead of the hard-coded color="red" found in the
> widgets.
> Files affected (as far as I can tell): htmlMenuRenderer.java and
> htmlFormRenderer.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
