[
https://issues.apache.org/jira/browse/OFBIZ-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Crum updated OFBIZ-671:
------------------------------
Attachment: formwidget.patch
Improved form widget patch. Changed focus-widget to focus-field-name, changed
/r/n to appendWhitespace method calls.
I kept the markup formatting in the patch. This will be invaluable during the
UI refactor. Just look at the markup this form widget outputs and see for
yourself. If it becomes an issue, I promise I will remove it after the
refactoring effort.
I kept the new properties. Even David Jones will understand that the widgets
are inconsistent when it come to id and style assignments. Some elements
support it, others don't.
My hope is that this patch will get committed so that the UI refactoring can
get started. I strongly recommend taking another look at it afterwards because
it can use some work. I found a lot of redundant code, and things that could be
implemented better by using better OOP in the java files, plus Chris Howe has
made a good suggestion about having a <styling> section. This patch is a step
in the right direction, but there is so much more that can be done to improve
the form widget.
> Remove HTML styling code from widgets
> -------------------------------------
>
> Key: OFBIZ-671
> URL: https://issues.apache.org/jira/browse/OFBIZ-671
> Project: OFBiz (The Open for Business Project)
> Issue Type: Sub-task
> Components: framework
> Reporter: Adrian Crum
> Priority: Minor
> Attachments: formwidget.patch, formwidget.patch, menuwidget.patch,
> menuwidget.patch, treewidget.patch
>
>
> Widgets have embedded styling code in them. Styling should be left to the css
> files. A CSS class should be created called "alert" or something similar, and
> that class should be used instead of the hard-coded color="red" found in the
> widgets.
> Files affected (as far as I can tell): htmlMenuRenderer.java and
> htmlFormRenderer.java.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
