Jacopo,
+1 for hiding incomplete functions. Such changes to codes (to hide incomplete features) can live
(and die) with the release branch, never to be merged into trunk.
So, yes, your suggestion makes a lot of sense.
Jonathon
Jacopo Cappellato wrote:
Walter,
apart from my previous remark on the approach to follow, I agree with
you that it would be great to see these items fixed asap in the trunk,
and thanks for your review.
After a quick review of the issues in your list, there is a comment I
can do: some of the features in OFBiz are not fully implemented (or
maintained), so they can be used in limited use cases (and fail with
others).
For example, billing accounts, as they are currently implemented, are
far from perfect and, in a production system, should be used only in
limited use cases; fixing/completing the billing account processes will
not be an easy task and the maintainers of the release branch could also
consider to hide the billing account support to the users, instead of
waiting for someone to complete the implementation of them.
Does it make sense?
Jacopo
Walter Vaughan wrote:
MINUS 42 votes!!!!
We have *calculation* issues in the Jira issues that need to be either
fixed or marked as closed.
These are not features. These are places that ofBiz generates
incorrect values, stores bad data, and does the wrong thing.
Does anyone think that it won't create 10 times more effort to fix
these in both a release and trunk branch?
Feature lock TODAY. Fix/Close these issues. Branch, then resume the
feature/framework changes...
jira number affects patch? description
885 accounting no multiple item issuances from different
sources generates only one tax adjustment
896 accounting no actions performed after an accepted payment
could cause that payment record to be rolled back
876 order calculation yes multiple problems with editing
orders that contain promotion items
870 shipping no Shipping Settings in XML don't match
Presented Options in New Order Shipping
830 inventory yes problems when receiving inventory for which
backorder exists
765 customers no Create New Customer fails if done after
initial/aborted anonymous checkout
732 orders no passing "processorder" request can create an
order without shipping or payment information
714 accounting no Adding another product to an order with a
marketing component product causes mixups in accounting, manufacturing
and inventory.
681 accounting no Wrong amount authorized for orders with
credit card and billing account
578 order calculation no problems with billing account
customer orders
559 order calculation no ability to add a tracking code or
campaign to a sales order
482 order calculation yes Invoice generation from order fails
if there is a percent item adjustment
424 order calculation no Order edit items/add item blows away
item adjustments
314 order calculation no Items in Shopping cart are lost on
login.
312 shipping no picklist shows incorrect quantities for out
of stock items
224 order calculation no Problem with approximations if the
ShoppingCart.basePrice has more than three decimal digits
223 order calculation no CartShipInfo objects are not
properly cloned when shopping cart items are exploded.
74 order payment no billing account error in checkout
Walter
