Jonathon,
I'll discuss this with a colleague.
As I understand first option is to send you
two archives, one with the original distribution we
downloaded in January and a second one also including
our changes.
Second option is to download the next release (coming these days?),
merge this and send you the pre-merged archive to do a check.
I've got an account at https://issues.apache.org/jira/browse/OFBIZ
Is it correct that I will have to attach a large archive to an issue
created in advance by yourself or myself?
If you're going to create the initial issue (mentioned in your last
posting)
please send me the issue number. I'll also put a link on that wiki
page.
Thanks for your support!
Regards.
Karl
-----Ursprüngliche Nachricht-----
Von: Jonathon -- Improov [mailto:[EMAIL PROTECTED]
Gesendet: Montag, 23. April 2007 13:38
An: dev@ofbiz.apache.org
Betreff: Re: AW: Ofbiz Contribution Proposal
Karl,
It's a great offer on your part too, to let us have those codes!
If you've done a merge with OFBiz trunk on 2007-01-05, that means you
already know how to keep in
step with OFBiz trunk head! You can actually do what I do, on your
own.
That said, if you still need my help, see the following.
These are what I'll need from you:
a. Exact OFBiz revision you started off from.
(Try to send me a tarball of that revision so I don't have to do
a SVN
download which can be a real pain thanks to the 35MB of 3rd-party
libraries. My own SVN doesn't include those 35MB or 3rd-party
binaries; let
me know if you want advise on how to cut a lean SVN without
binaries.)
b. Tarball of your latest work you want merged with OFBiz trunk head.
(Please do an "export"; I don't need the .cvs files.)
What I will give you is a tarball of this: OFBiz trunk head (I'll
state revision for our
reference) married with the latest of your work.
You will have to test this tarball over time, get back to me about
problems, and I'll keep sending
you fixed tarballs (or deltas, rather). We won't even have to touch
the official OFBiz SVN.
For the initial "review", I will at least make sure it compiles and
runs. You will have to test
your own functions to see they still work with the latest updates
from OFBiz SVN.
So, here's the summary of the process:
1. We merge latest of OFBiz with your stuff.
2. Review A: We make sure your stuff still works.
3. Review B: We (or community) make sure the general OFBiz stuff
still works.
4. We submit a patch (diff OFBiz to Your_work) to community.
And then the ball will be in their (committers') court.
Generally, you can pretty much stop at step 2 if all you want is the
latest of OFBiz working with
your stuff. If you had done your customizations in a
backward-compatible manner, step 3 won't be
very difficult or even necessary at all.
Jonathon
Eilebrecht, Karl (Key-Work) wrote:
Hi Jonathan, hi Chris,
thank you for your feedback (and also thank you for stiring up a
hornet's nest ;-) )
@Chris: I will try to answer your questions on the wiki page:
I think this is more comfortable to retrace.
@Jonathan: It's a great offer you made to take a look on our code
and to
evtl. merge it! What's the best way to provide the code to you?
I'll have to prepare some things before:
- for historical reasons we have a CVS repository and I
or one of my colleagues will set up an SVN client. Is it more
convenient to
you to get an archive for the first review or would you recommend
to
pump the sources into a repository? (where?)
- I already have added the Apache-Header (ASL) to all of the
classes
we might contribute.
- I'll have to replace all tabs in the sources by 4 spaces.
The rest I think should be not too complex, our last framework
merge (with trunk) was on 2007-01-05, I don't think there are
dramatic low level interface changes since then.
We have already switched to Java 6 but all the classes to be
contributed
are compileable with Java 1.4.
Regards.
Karl
BTW: During the next weeks there may be some "communication delays"
because I'll not be in the office all the time. So please don't worry
if an email answer needs some days, thanks!
-----Ursprüngliche Nachricht-----
Von: Chris Howe [mailto:[EMAIL PROTECTED]
Gesendet: Samstag, 21. April 2007 08:33
An: dev@ofbiz.apache.org
Betreff: Re: Ofbiz Contribution Proposal
Hi Karl,
I had the opportunity today to quickly read over your
introductions.
And must say it looks very interesting. Unfortunately, for my
being
able to add input to the process, the improvements are in areas as
an
OFBiz user, that I take for granted and don't really get my hands
dirty
with.
I'll need to read over the transaction part again to ask any
intelligent questions, so I'll leave that for later.
The custom SQL stuff looked very interesting and probably one of
the
larger areas of benefit as more and more people are getting to the
point of locating bottlenecks in their applications. I was
wondering
if there might be some benefit in encapsulating the stored sql
statements it in an XML structure to be able to better take
advantage
of some META data/commenting that you discussed as well as
potential of
some reusability and structuring of those custom statements.
Perhaps, I need to reread the logging discussion again, and ask if
this
is largely supported among other databases, but can't most of these
logging of the sql statements be handled in the database's log, if
configured to do so? I recall a mention that the developer may not
have sufficient access to the database server to ascertain the
database
logs...is this case where the logging proposal would be more
beneficial?
Thank you and Key-Work very much for bringing these enhancements
back
to the community!
Chris
--- "Eilebrecht, Karl (Key-Work)" <[EMAIL PROTECTED]>
wrote:
Hi,
we use Ofbiz (mostly the entity engine) for over 2 years now.
