[ 
https://issues.apache.org/jira/browse/OFBIZ-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-942:
------------------------------------

    Attachment: fileupload-content.patch
                fileupload.patch

The two patch file will fix the warnings.
Could you please review them before I commit?
Please focus on:
1) the name I've chosen for the new properties
2) the hardcoded default values I've set in the patch for content component (we 
should probably create a central static method in the base component... but 
this was not the goal of this issue)
3) is it ok to add a new folder, "tmp", to the runtime folder?


> Warnings after upgrade of common* jars
> --------------------------------------
>
>                 Key: OFBIZ-942
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-942
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Improvement
>          Components: content, framework
>            Reporter: Jacopo Cappellato
>         Assigned To: Jacopo Cappellato
>            Priority: Minor
>         Attachments: fileupload-content.patch, fileupload.patch
>
>
> ****************************************
> *        webapp component                   *
> ****************************************
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:34: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
> import org.apache.commons.fileupload.DiskFileUpload;
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:132: 
> warning: [deprecation] 
> isMultipartContent(javax.servlet.http.HttpServletRequest) in 
> org.apache.commons.fileupload.FileUploadBase has been deprecated
>         boolean isMultiPart = FileUpload.isMultipartContent(request);
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:135: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload upload = new DiskFileUpload();
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:135: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload upload = new DiskFileUpload();
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:135: 
> warning: [deprecation] DiskFileUpload() in 
> org.apache.commons.fileupload.DiskFileUpload has been deprecated
>             DiskFileUpload upload = new DiskFileUpload();
> framework\webapp\src\org\ofbiz\webapp\event\ServiceEventHandler.java:140: 
> warning: [deprecation] parseRequest(javax.servlet.http.HttpServletRequest) in 
> org.apache.commons.fileupload.FileUploadBase has been deprecated
>                 uploadedItems = upload.parseRequest(request);
> ****************************************
> *         content component                   *
> ****************************************
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:53:
>  warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
> import org.apache.commons.fileupload.DiskFileUpload;
> applications\content\src\org\ofbiz\content\data\DataResourceWorker.java:36: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
> import org.apache.commons.fileupload.DiskFileUpload;
> applications\content\src\org\ofbiz\content\layout\LayoutWorker.java:32: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
> import org.apache.commons.fileupload.DiskFileUpload;
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:81:
>  warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:81:
>  warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:81:
>  warning: [deprecation] DiskFileUpload() in 
> org.apache.commons.fileupload.DiskFileUpload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:85:
>  warning: [deprecation] parseRequest(javax.servlet.http.HttpServletRequest) 
> in org.apache.commons.fileupload.FileUploadBase has been deprecated
>                 lst = dfu.parseRequest(request);
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:346:
>  warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:346:
>  warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:346:
>  warning: [deprecation] DiskFileUpload() in 
> org.apache.commons.fileupload.DiskFileUpload has been deprecated
>             DiskFileUpload dfu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\content\UploadContentAndImage.java:350:
>  warning: [deprecation] parseRequest(javax.servlet.http.HttpServletRequest) 
> in org.apache.commons.fileupload.FileUploadBase has been deprecated
>                 lst = dfu.parseRequest(request);
> applications\content\src\org\ofbiz\content\data\DataResourceWorker.java:179: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\data\DataResourceWorker.java:179: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\data\DataResourceWorker.java:179: 
> warning: [deprecation] DiskFileUpload() in 
> org.apache.commons.fileupload.DiskFileUpload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\data\DataResourceWorker.java:184: 
> warning: [deprecation] parseRequest(javax.servlet.http.HttpServletRequest) in 
> org.apache.commons.fileupload.FileUploadBase has been deprecated
>             lst = fu.parseRequest(request);
> applications\content\src\org\ofbiz\content\layout\LayoutWorker.java:57: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\layout\LayoutWorker.java:57: 
> warning: [deprecation] org.apache.commons.fileupload.DiskFileUpload in 
> org.apache.commons.fileupload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\layout\LayoutWorker.java:57: 
> warning: [deprecation] DiskFileUpload() in 
> org.apache.commons.fileupload.DiskFileUpload has been deprecated
>         DiskFileUpload fu = new DiskFileUpload();
> applications\content\src\org\ofbiz\content\layout\LayoutWorker.java:60: 
> warning: [deprecation] parseRequest(javax.servlet.http.HttpServletRequest) in 
> org.apache.commons.fileupload.FileUploadBase has been deprecated
>            lst = fu.parseRequest(request);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to