[ 
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian Crum updated OFBIZ-1096:
-------------------------------

    Attachment: pager.patch

Jeremy,

Your latest patches are much improved. Instead of going back and forth in Jira 
comments, I applied your patches to my local copy and made some corrections. 
They are in the pager.patch attachment.

A few things still need to be done:

1. HtmlFormRenderer.java - change the \n characters to appendWhitespace calls
2. ModelForm.java and the widget-form.xsd files - the nav-* properties really 
aren't needed. As long as you have the PaginateStyle available for the 
outermost container, anyone can style its contained elements.
3. It would be nice to have the select box appear last. That way, the other 
elements follow the established pattern:

Previous - 1 of x - Next - Page [select box]

Once those changes are made, then you will have an excellent contribution. I 
look forward to seeing it in the project.


> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, 
> HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, 
> ModelForm-2.patch, ModelForm.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files 
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well 
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with 
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk 
> version.
> PS: I would like to use this issue to have your comments on another pager 
> issue. The current implementation doesn't support pages that display more 
> than one list form for the obvious reason that the only the parameters 
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to 
> differentiate the form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to