[ 
https://issues.apache.org/jira/browse/OFBIZ-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508576
 ] 

Adrian Crum commented on OFBIZ-1096:
------------------------------------

Maybe something was misunderstood in my point #2.

If you have this line in HtmlFormRenderer.java:

buffer.append("<div 
class=\"").append(modelForm.getPaginateStyle()).append("\">");

then you don't need lines like this:

buffer.append("<li class=\"").append(modelForm.getPaginateFirstStyle());

Instead, the contained elements can be styled specifically:

buffer.append("<li class=\"nav-first\"");

If someone wants to change the pagination style, they only need to specify the 
style for the outermost container (the <div> element) because the CSS classes 
they use will style the contained elements via descendent selectors (like I did 
in maincss.css). Doing so will eliminate all of the unnecessary form widget 
properties.

In other words, the only style the xml file, the model form, and the renderer 
needs to accomodate is the outermost paginate style.



> Enhanced pager for Forms
> ------------------------
>
>                 Key: OFBIZ-1096
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1096
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: form-dtd.patch, form-dtd_2.patch, 
> HtmlFormRenderer-2.patch, HtmlFormRenderer.patch, maincss.patch, 
> ModelForm-2.patch, ModelForm.patch, pager-2.patch, pager.patch
>
>
> I am currently working on an enhanced pager. The change affects a few files 
> in the framework but i tried to make it as small as possible.
> The main enhancement is to add "First" and "Last" button in the pager as well 
> as a javascript combobox to quickly jump to any page.
> It is inspired by the Neogia implementation but rewritten to integrate with 
> the existing pager.
> I will attach the patches as i apply the changes to the latest SVN trunk 
> version.
> PS: I would like to use this issue to have your comments on another pager 
> issue. The current implementation doesn't support pages that display more 
> than one list form for the obvious reason that the only the parameters 
> VIEW_SIZE and VIEW_INDEX are used in the pager, which lacks a parameter to 
> differentiate the form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to