[
https://issues.apache.org/jira/browse/OFBIZ-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515521
]
Jacopo Cappellato commented on OFBIZ-1159:
------------------------------------------
David S.,
your patch is interesting and a good starting point to implement the update of
existing contact mechs imported from eBay; however, after a quick review, there
are two issues that you should resolve before committing your work to svn:
1) when you try to fetch existing contact mechs for a party, you use the
following code:
GenericValue contactMech =
EntityUtil.getFirst(delegator.findByAnd("PartyContactMechPurpose",
UtilMisc.toMap("partyId", partyId,
"contactMechPurposeTypeId","SHIPPING_LOCATION")));
unfortunately in this way you can also select an expired contact mech. Instead
of using a findByAnd you should try to make a call to one of the methods of the
ContactHelper class (or ContactMechWorker class) in the party component.
2) in the checkPartyAddress, checkPartyEmail etc... before running the update
(that will expire the existing contact mech and create a new one, even if they
are identical) you should compare field-to-field the two addresses/email....
Jacopo
> Integration with eBay (import of orders and export of auctions).
> ----------------------------------------------------------------
>
> Key: OFBIZ-1159
> URL: https://issues.apache.org/jira/browse/OFBIZ-1159
> Project: OFBiz
> Issue Type: New Feature
> Components: order, product
> Reporter: Jacopo Cappellato
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: checkingForExistingParties.patch,
> importOrdersFromEbay10.patch, importOrdersFromEbay11.patch,
> importOrdersFromEbay13.patch, importOrdersFromEbay14.patch,
> importOrdersFromEbay15.patch, importOrdersFromEbay16.patch
>
>
> Integration with eBay (import of orders and export of auctions):
> development of a set of services and events, and some screens to manage
> import/export of data to/from eBay auctions API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
