[
https://issues.apache.org/jira/browse/OFBIZ-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518668
]
Bilgin Ibryam commented on OFBIZ-1189:
--------------------------------------
David,
I tested it with r562836 and it works fine.
Looks like it is affected from your changes (ProductStore.headerApprovedStatus
feature r562843).
But the changes you did are correct. The error occurs because the seca
approves the items, approves the order, completes the items and completes the
order. Then the first started service for approving returns the error.
In OrderServices.java:1973 i see that when we try to change the order status to
the same status, we are not returning error but only a warning log and success .
So the solution i offer is similar: Instead of returning error when the
order_status_change is not valid, we can log warning and return success. What
you think ?
> Cannot approve digital product orders
> -------------------------------------
>
> Key: OFBIZ-1189
> URL: https://issues.apache.org/jira/browse/OFBIZ-1189
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Fix For: SVN trunk
>
> Attachments: order.patch
>
>
> Hi all,
> There is a bug when approving orders that contains only digital products.
> If you create an order that contains only digital products and then try to
> approve it you will get ERROR : Could not change order status ; status is not
> a valid change.: [ORDER_COMPLETED] -> [ORDER_APPROVED]
> The reason is that there is seca rule and checkDigitalItemFulfillment service
> will put all the items to ITEM_COMPLETED status. Then another seca calls
> checkOrderItemStatus and the order is also in put in ORDER_COMPLETED status.
> All the items are completed and the order is also completed, everything looks
> fine, but the service called in the beginning to approve the order generates
> the error [ORDER_COMPLETED] -> [ORDER_APPROVED] is not a valid change....
> Any ideas what should be the flow in approving and completing an order in
> cases where all items are completed while approving ?
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
