[jira] Updated: (OFBIZ-1201) rev 560970 broke javascript

[Wickersheimer Jeremy (JIRA)]

     [ 
https://issues.apache.org/jira/browse/OFBIZ-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wickersheimer Jeremy updated OFBIZ-1201:
----------------------------------------

    Attachment: ofbiz-1201.patch

Here is the patch to revert the ampersands. I also changed the if blocks for 
the payment method to if / elseif / .. / else error as it is easier to read 
this way.

> rev 560970 broke javascript
> ---------------------------
>
>                 Key: OFBIZ-1201
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1201
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce
>    Affects Versions: SVN trunk
>            Reporter: Wickersheimer Jeremy
>            Priority: Minor
>         Attachments: ofbiz-1201.patch
>
>
> Another small issue i found out:
> setPaymentInformation 
> (ecommerce/webapp/ecommerce/order/paymentinformation.ftl) uses javascript for 
> "Billing address is the same as the shipping address"
> rev 560970 escaped the & => &amps; , but in the Javascript there is no need 
> to escape HTML characters ... the url used in the window.location.replace 
> still contain the escaped &amps; 
> I will attach the patch for this file, maybe rayb should check if that broke 
> other java scripts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.