[
https://issues.apache.org/jira/browse/OFBIZ-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David E. Jones closed OFBIZ-1198.
---------------------------------
Resolution: Fixed
Okay, a some improvements that fix this issue are now in SVN, along with
comments for handling related issues.
I was able to reproduce this through some interesting stuff though it was a bit
of a pain as the Order Manager Order Entry functionality is currently broken
for placing this sort of order, or I couldn't figure out how to anyway... :(
For more details on the change for this and recommendations for related things
here is the commit log:
Some changes to more robustly get an address for recalculating tax, AND made it
optional so that if there is no address (which we technically allow in OFBiz)
it won't blow up but instead just won't recalculate tax; note that orders in
that category generally don't have tax in the first place; this was reported in
Jira #OFBIZ-1198; also added note for handling face-to-face or immediately
fulfilled orders, which would also be applicable for rental orders... ie that
special case needs to be identified by appropriate criteria and handled as
needed here in the OrderServices.recalcOrderTax method AND in the related
method that works on the cart when an order is placed, namely
CheckOutHelper.makeTaxContext
> Canceling rental and digital product orders is broken
> -----------------------------------------------------
>
> Key: OFBIZ-1198
> URL: https://issues.apache.org/jira/browse/OFBIZ-1198
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: tax.patch
>
>
> Hi all,
> Currently orders that do not have shipping address (orders that contains only
> digital and rental products) cannot be can canceled.
> The generated error is:
> [java] 2007-08-12 15:30:49,640 (http-0.0.0.0-8443-Processor3) [
> ServiceDispatcher.java:410:ERROR] Service Error [calcTax]: The address(es)
> used for tax calculation did not have State/Province or Country or other tax
> jurisdiction values set, so we cannot determine the taxes to charge.
> [java] 2007-08-12 15:30:49,640 (http-0.0.0.0-8443-Processor3) [
> TransactionUtil.java:291:WARN ]
> [java] ---- exception report
> ----------------------------------------------------------
> [java] [TransactionUtil.setRollbackOnly] Calling transaction
> setRollbackOnly; this stack trace shows where this is happening:
> [java] Exception: java.lang.Exception
> [java] Message: Service Error [calcTax]: The address(es) used for tax
> calculation did not have State/Province or Country or other tax jurisdiction
> values set, so we cannot determine the taxes to charge.
> [java] ---- stack trace
> ---------------------------------------------------------------
> [java] java.lang.Exception: Service Error [calcTax]: The address(es)
> used for tax calculation did not have State/Province or Country or other tax
> jurisdiction values set, so we cannot determine the taxes to charge.
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:291)
> [java]
> org.ofbiz.entity.transaction.TransactionUtil.rollback(TransactionUtil.java:238)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:414)
> [java]
> org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:210)
> [java]
> org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:136)
> [java]
> org.ofbiz.order.order.OrderServices.recalcOrderTax(OrderServices.java:1381)
> The applied patch fixes the bug.
> Regards,
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
