Yes I can testify, I learned a lot from David's (and other) remarks ! This oblige you to think better, notably when it comes to use existing tools and practices in OFBiz :o)
On the other hand, there are more and more Jira issues pending and this begin to worry me a bit. I would not like that new comers think that their patches are neglicted. It seems that we (commiters) are more and more busy which indubitably is good for us but should not be bad for the project. Nevertheless, I know we try all to do our best everyday and I'm confident in the future... Jacques De : "Jonathon -- Improov" <[EMAIL PROTECTED]> > Agreed. > > Men in the boxing ring are always preferred over those outside, IMHO. > > I think that strict standards and a clean project will attract a lot of good > contributors. I've > not heard of a college course that has strict entry requirements see a lack > of applications; the > converse is true. > > Jonathon > > David E Jones wrote: > > > > > > Adrian Crum wrote: > >> If we were to "take a stand" and reject changes that don't strictly > >> adhere to best practices, then there would be a lot of work left out > >> of OFBiz (I see commits that don't follow best practices almost on a > >> daily basis). I agree that it's tempting to go that route. Maybe once > >> the developer/committer community gets large enough, we can afford to > >> take a tougher stand. Right now we would be shooting ourselves in the > >> foot in doing so. > > > > I agree with everything else you wrote Adrian, but I don't think I agree > > with these last two sentences. I've been pretty hard on some of your > > stuff, and lots of other people's stuff, and the reason why is I think > > that feedback and a request to improve/correct is the best way to do two > > things: > > > > 1. help people understand best practices and the tools that are > > available, perhaps helping them move toward becoming a committer > > > > 2. improve the general quality of the project (in terms of utility and > > aesthetics) > > > > I don't think doing so will scare people away. The reactions I usually > > get are both good in a way: > > > > 1. an appreciation of the feedback and willingness or eagerness to take > > advantage of the ideas > > > > 2. a good brawl over the best way to do things that eventually leads to > > great improvement in the project, and probably someone who will stay > > involved in the project for a long time > > > > -David > > > > >
