Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

[Michael Brohl]

These are good points, I wasn't aware of this and just saw the (in my view) unnecessary extra lines of code.

Thanks,

Michael


Am 11.12.17 um 09:55 schrieb Jacopo Cappellato:

I will check my latest commits and change this back where it is reasonable (i.e. where we have concatenations). Luckily, I just started this this morning and not during the heavier commits over the weekend. This reminds me that it is NOT a good idea to do such changes along with the commits of patches, it's too confusing.

On Mon, Dec 11, 2017 at 9:31 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

[...]
Also for OFBIZ-9872 the Jira lacks a description to possibly understand
why theses changes (notably why you rightly removed the "if
(Debug.verboseOn())" test because it's done at the bottom level with  "if
(isOn(level)) {"

There is actually a valid reason for maintaining the pattern:

if (Debug.verboseOn()) {
     Debug.logVerbose(string + concatenation + here);
}

In fact string concatenation (in any of its forms) adds some overhead
(computational, memory, garbage collection); since the string concatenation
is done before calling Debug.logVerbose (or similar methods), but it is
only useful if that log level is on (otherwise the call to logVerbose will
not produce any output) then it is wise to perform the verboseOn() check
before: if the call returns a false then at runtime the sting concatenation
will not be executed at all.

Jacopo

smime.p7s
Description: S/MIME Cryptographic Signature