There is a reason why we had this "mass-update" topic many times in multiple threads. Seeking out patterns of code all over the code base might be dangerous. And that is why I always recommend refactoring by focusing very intensely on a specific piece of code with very careful attention to the context surrounding that code.
My recommendation makes coding slower, but it makes things cleaner and safer. On Dec 13, 2017 4:02 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> wrote: > Thanks Nicolas, > > My fast review was not enough, I'll fix that :) > > Jacques > > > Le 13/12/2017 à 13:46, Nicolas Malin a écrit : > >> >> >> Le 13/12/2017 à 13:43, jler...@apache.org a écrit : >> >>> @@ -2157,7 +2157,7 @@ public class InvoiceServices { >>> return ServiceUtil.returnError(Servic >>> eUtil.getErrorMessage(serviceResults)); >>> } >>> if (Debug.verboseOn()) { >>> - Debug.logVerbose("Creating Invoice Item with amount >>> " + returnPrice + " and quantity " + quantity >>> + if (Debug.verboseOn()) Debug.logVerbose("Creating >>> Invoice Item with amount " + returnPrice + " and quantity " + quantity >>> + " for shipment [" + >>> item.getString("shipmentId") + ":" + item.getString("shipmentItemSeqId") >>> + "]", module); >>> } >>> >> Jacques, maybe you failed your replaceAll because you have a double check >> sometime ^^ >> >> Nicolas >> >> >