Hi everyone,

Only did a quick look at the 2 patches.

I think the improvement is incomplete and effectively removed the datasource 
configurations like MSSQL, MySQL, Oracle etc. Developers (like me) using these 
databases will require additional work to find and apply the missing 
configurations. 

So my vote is +1, to keep the different datasource configurations.

Regards,
James Yong

On 2018-01-07 18:36, Michael Brohl <michael.br...@ecomify.de> wrote: 
> Hi everyone,
> 
> please have a look at the issue mentioned below and express your 
> opionion if we should remove the different schema configurations from 
> the main entityengine.xml or if we should keep them.
> 
> Thanks,
> 
> Michael
> 
> 
> Am 07.01.18 um 11:23 schrieb Pierre Smits (JIRA):
> >      [ 
> > https://issues.apache.org/jira/browse/OFBIZ-8230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315152#comment-16315152
> >  ]
> >
> > Pierre Smits commented on OFBIZ-8230:
> > -------------------------------------
> >
> > Closing an improvement ticket unilaterally, while you're not the assignee, 
> > is not in line with the Apache Way.
> > This would - at least - require a consensus of the community (or at least 3 
> > binding votes, as this is a procedural matter).
> >
> >
> >
> >> Disentangle platform specific entity engine schemas
> >> ---------------------------------------------------
> >>
> >>                  Key: OFBIZ-8230
> >>                  URL: https://issues.apache.org/jira/browse/OFBIZ-8230
> >>              Project: OFBiz
> >>           Issue Type: Improvement
> >>           Components: framework
> >>     Affects Versions: Trunk
> >>             Reporter: Pierre Smits
> >>             Assignee: Pierre Smits
> >>             Priority: Minor
> >>               Labels: database, devops, refactoring
> >>          Attachments: OFBIZ-8230-entityengine-postgresql.xml.patch, 
> >> OFBIZ-8230-entityengine.xml.patch
> >>
> >>
> >> Disentangle entity engine schemas for specific rdbms platforms from 
> >> entityengine.xml
> >
> >
> > --
> > This message was sent by Atlassian JIRA
> > (v6.4.14#64029)
> 
> 
> 

Reply via email to