Hi Rishi, Could you please update commit log and use "Reverted: as prefix? https://cwiki.apache.org/confluence/x/TxjtAw
Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Tue, Mar 13, 2018 at 7:19 PM, <ri...@apache.org> wrote: > Author: rishi > Date: Tue Mar 13 13:49:23 2018 > New Revision: 1826633 > > URL: http://svn.apache.org/viewvc?rev=1826633&view=rev > Log: > Improved: Improve GeneralLedgerServices to set transaction date as > payment's effective date. Reverting my commit due to buildbot failure > message will check and commit it back. > (OFBIZ-10239) > > Modified: > ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/ > GeneralLedgerServices.xml > > Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/ > minilang/ledger/GeneralLedgerServices.xml > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/ > applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev= > 1826633&r1=1826632&r2=1826633&view=diff > ============================================================ > ================== > --- > ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml > (original) > +++ > ofbiz/ofbiz-framework/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml > Tue Mar 13 13:49:23 2018 > @@ -2404,7 +2404,6 @@ under the License. > <set field="createAcctgTransAndEntriesInMap.acctgTransTypeId" > value="OUTGOING_PAYMENT"/> > <set field="createAcctgTransAndEntriesInMap.partyId" > from-field="partyId"/> > <set field="createAcctgTransAndEntriesInMap.paymentId" > from-field="payment.paymentId"/> > - <set field="createAcctgTransAndEntriesInMap.transactionDate" > from-field="payment.effectiveDate"/> > <set field="createAcctgTransAndEntriesInMap.acctgTransEntries" > from-field="acctgTransEntries"/> > <call-service service-name="createAcctgTransAndEntries" > in-map-name="createAcctgTransAndEntriesInMap"> > <result-to-field result-name="acctgTransId"/> > @@ -2649,7 +2648,6 @@ under the License. > <set field="createAcctgTransAndEntriesInMap.acctgTransEntries" > from-field="acctgTransEntries"/> > <set field="createAcctgTransAndEntriesInMap.acctgTransTypeId" > value="PAYMENT_APPL"/> > <set field="createAcctgTransAndEntriesInMap.glFiscalTypeId" > value="ACTUAL"/> > - <set field="createAcctgTransAndEntriesInMap.transactionDate" > from-field="payment.effectiveDate"/> > <set field="createAcctgTransAndEntriesInMap.paymentId" > from-field="paymentApplication.paymentId"/> > <set field="createAcctgTransAndEntriesInMap.invoiceId" > from-field="paymentApplication.invoiceId"/> > <if-compare field="isReceipt" operator="equals" type="Boolean" > value="true"> > > >
