Actually I expect to put this feature on the server to demonstrate it, for 
people to test it and use it on their side

Still a WIP...

Jacques


Le 16/03/2018 à 09:30, Scott Gray a écrit :
That's the problem though, this domain isn't available for that purpose
either.

You're also using infra volunteer time for feature development rather than
project support.

Regards
Scott

On 16/03/2018 7:29 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com>
wrote:

I'm sorry, this is a temporary poor man solution. I have no other domain
available.

Jacques


Le 16/03/2018 à 03:08, Scott Gray a écrit :

I guess what Michael is getting at, is that the demo server is for demos,
it's not intended for use as a development sandbox.

As far as I can tell you don't *need* to be using the demo servers for
this, it's just convenient for you.  But the problem is, if you're
modifying the code on the demos and someone reports a problem, the rest of
us will go looking for a problem in the branches that doesn't exist.

Long story short, probably not an appropriate use of the demo instances.

Regards
Scott

On 16 March 2018 at 08:34, Jacques Le Roux <jacques.le.r...@les7arts.com>
wrote:

Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on
a replacing solution.

This other solution still uses the same (slightly modified)
externalServerLoginCheck preprocessor.
FYI this solution is still based on AutoUserLogin cookies, and uses now
Ajax and CORS, instead of  ContextFilter.

So to test that on a server I need a small modification on the current
code:

Index: framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
ol/ExternalLoginKeysManager.java
===================================================================
--- framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
ol/ExternalLoginKeysManager.java (revision 1826773)
+++ framework/webapp/src/main/java/org/apache/ofbiz/webapp/contr
ol/ExternalLoginKeysManager.java (working copy)
@@ -182,18 +182,15 @@
           Delegator delegator = (Delegator)
request.getAttribute("delegato
r");
           HttpSession session = request.getSession();

-        // The target server does not allow external login by default
-        boolean useExternalServer = EntityUtilProperties.getProper
tyAsBoolean("security",
"use-external-server", false);
-        String sourceWebappName = request.getParameter(SOURCE_SE
RVER_WEBAPP_NAME);
-        if (!useExternalServer || sourceWebappName == null) return
"success"; // Nothing to do here
-
           try {
               String userLoginId = null;
               String authorizationHeader = request.getHeader("Authorizati
on");
               if (authorizationHeader != null) {
                   Claims claims = returnsClaims(authorizationHeader);
                   userLoginId = getSourceUserLoginId(claims );
-                boolean jwtOK = checkJwt(authorizationHeader,
userLoginId, getTargetServerUrl(request), UtilHttp.getApplicationName(re
quest));
+                boolean jwtOK = checkJwt(authorizationHeader,
userLoginId, "","");
                   if (!jwtOK) {
                       // Something unexpected happened here
                       Debug.logWarning("*** There was a problem with the
JWT token, not signin in the user login " + userLoginId, module);

I did this modification on the trunk demo. I have no other solution to
test my work.

Also I had to request the installation of HTTPS headers handling by
infra:
https://issues.apache.org/jira/browse/INFRA-16189

Jacques



Le 15/03/2018 à 17:37, Michael Brohl a écrit :

I still do not understand why you had to change the demo instance for
your developments. What was this change?

Michael


Am 15.03.18 um 14:46 schrieb Jacques Le Roux:

Because for testing changes for OFBIZ-9833 I had to make a slight change
on the trunk demo instance and needed to restart but

./gradlew --no-daemon "ofbiz --shutdown"

Does not always behaves well, at least on demos VM where there is 3
instances

So you get unstable situation and have to use "kill -9".

Anyway some data were not well loaded. A loadAll fixed it.

HTH

Jacques


Le 15/03/2018 à 13:56, Michael Brohl a écrit :

Of course it should read: "I try to understand why trunk demo was
broken while the trunk codebase seems to have no issues."

Michael


Am 15.03.18 um 13:51 schrieb Michael Brohl:

To be more clear: I try to understand why trunk demo was broken while
the trunk demo seems to have no issues.

Michael


Am 15.03.18 um 13:36 schrieb Jacques Le Roux:

Ho, it would be convoluted, please wait, WIP...
Jacques


Le 15/03/2018 à 12:37, Michael Brohl a écrit :

Jacques did changes he already reverted in the mantime, see his post
this morning.

Jacques, can you please explain what happened?


Am 15.03.18 um 12:24 schrieb Taher Alkhateeb:

Hi Rishi, I'm not getting any errors in the demo on my side? Could
it
be a web browser cache thing? I always fall in that trap myself.

On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki <
rishisolan...@gmail.com> wrote:

It seems something specific with deployment/data at demo instance,
locally
It is working. No issue with latest trunk fresh data.

Best,

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co

On Thu, Mar 15, 2018 at 1:19 PM, Rishi Solanki <
rishisolan...@gmail.com>
wrote:

Devs,

On browsing - https://demo-trunk.ofbiz.apach
e.org/webtools/control/
FindGeneric?entityName=Party

Received following exception, Any one facing the similar issue
with demo
please share. I'm looking into it and get back if find the root
cause for
the same.


Thanks!


Here is the error received on UI

========================================================
ERROR rendering error page [/error/error.jsp], but here is the
error text:
java.lang.IllegalArgumentException: Error running script at
location
[component://webtools/groovyScripts/entity/FindGeneric.groovy]:
org.codehaus.groovy.control.MultipleCompilationErrorsException:
startup
failed: General error during class generation:
java.lang.NoClassDefFoundError:
Unable to load class org.apache.ofbiz.widget.render
er.macro.MacroFormRenderer
due to missing dependency org/apache/ofbiz/widget/model/
ModelFormField$SubHyperlink
java.lang.RuntimeException: java.lang.NoClassDefFoundError:
Unable to
load class org.apache.ofbiz.widget.render
er.macro.MacroFormRenderer
due
to missing dependency org/apache/ofbiz/widget/model/
ModelFormField$SubHyperlink
at org.codehaus.groovy.control.CompilationUnit.
convertUncaughtExceptionToCompilationError(CompilationUnit.j
ava:1101)
at
org.codehaus.groovy.control.CompilationUnit.applyToPrimaryCl
assNodes(CompilationUnit.java:1079)
at org.codehaus.groovy.control.CompilationUnit.doPhaseOperation
(CompilationUnit.java:603)
at org.codehaus.groovy.control.CompilationUnit.processPhaseOper
ations(CompilationUnit.java:581)
at org.codehaus.groovy.control.CompilationUnit.compile(Compilat
ionUnit.java:558)
at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader
.java:298)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
ava:268)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
ava:254)
at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.j
ava:211)
at org.apache.ofbiz.base.util.GroovyUtil.parseClass(GroovyUtil.
java:195)
at org.apache.ofbiz.base.util.GroovyUtil.getScriptClassFromLoca
tion(GroovyUtil.java:159)
at org.apache.ofbiz.base.util.GroovyUtil.runScriptAtLocation(Gr
oovyUtil.java:206)
at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
il.java:342)
at org.apache.ofbiz.base.util.ScriptUtil.executeScript(ScriptUt
il.java:324)
at

========================================================

Rishi Solanki
Sr Manager, Enterprise Software Development
HotWax Systems Pvt. Ltd.
Direct: +91-9893287847
http://www.hotwaxsystems.com
www.hotwax.co




Reply via email to