Mmhhh, Jacques,I think this is problematic because it ties a special implementation for Tomcat to the service. I didn't see this anywhere else.
The issue (https://issues.apache.org/jira/browse/OFBIZ-10304) is a bit unclear and I don't get the purpose of this change.
Can you please explain more clearly which problem this changes solves and why we'll need org.apache.catalina.connector.RequestFacade as the type?
Thanks, Michael Am 21.03.18 um 21:53 schrieb jler...@apache.org:
Author: jleroux Date: Wed Mar 21 20:53:41 2018 New Revision: 1827439 URL: http://svn.apache.org/viewvc?rev=1827439&view=rev Log: Fixed: The "request" attribute type of the userLogin service is wrong (OFBIZ-10304) It should have been org.apache.catalina.connector.RequestFacade" instead of javax.servlet.http.HttpServletRequest see the Jira for details Modified: ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml Modified: ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?rev=1827439&r1=1827438&r2=1827439&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml (original) +++ ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml Wed Mar 21 20:53:41 2018 @@ -379,7 +379,7 @@ under the License. <service name="userLogin" engine="java" location="org.apache.ofbiz.common.login.LoginServices" invoke="userLogin"> <description>Used to Automatically Authenticate a username/password; create a UserLogin object</description> <implements service="authenticationInterface"/> - <attribute name="request" mode="IN" type="javax.servlet.http.HttpServletRequest" optional="true"/> + <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade" optional="true"/> </service> <service name="createUserLogin" engine="java" auth="false" location="org.apache.ofbiz.common.login.LoginServices" invoke="createUserLogin">
smime.p7s
Description: S/MIME Cryptographic Signature
