Thanks everyone for your thoughts and inputs.

Here <https://issues.apache.org/jira/browse/OFBIZ-10338> is the ticket
created for the same.

--
Thanks and Regards,
*Suraj Khurana* | Omni-channel OMS Technical Expert
*HotWax Commerce*  by  *HotWax Systems*
Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
Cell phone: +91 96697-50002

On Thu, Apr 12, 2018 at 2:27 PM, Arun Patidar <
arun.pati...@hotwaxsystems.com> wrote:

> +1 Suraj for the improvement.  Please see my comments inline:
>
>
> On Tue, Apr 10, 2018 at 4:54 PM, Suraj Khurana <
> suraj.khur...@hotwaxsystems.com> wrote:
>
>> Hello,
>>
>> There are some entities which could be renamed as per their usage.
>>
>>    - *OrderItemShipGroup*: It shows order ship groups and it doesn't
>>    contain anything at order item level. So, it could be re-named as
>>    *OrderShipGroup.*
>>    - *OrderItemShipGroupAssoc: *It do not maintain any association type,
>> it
>>    just contains order item with respect to ship group, so this could be
>>    re-named as *OrderItemShipGroup *to maintain consistency and code
>>    readablity.
>>
>>
>  You can rename 'OrderItemShipGroupAssoc'  to 'OrderShipGroupItems' or 
> 'OrderShipGroupMember'.
> Renaming it to exisitng entity can be complex and confusing for end user.
>
>
>
> --
> Thanks & Regards
> ---
> Arun Patidar
> Manager, Enterprise Software Development
>
> www.hotwaxsystems.comwww.hotwax.co
>
>
>
>
>
>
>
>> I know that these entities are crucial part of OOTB data model since
>> inception. Having thought in mind that 'Naming should be self
>> explanatory',
>> this is a proposal and It would be great to hear communities thought on
>> this topic.
>>
>> Please share your opinions on this.
>>
>> --
>>
>> Thanks and Regards,
>> *Suraj Khurana* | Omni-channel OMS Technical Expert
>> *HotWax Commerce*  by  *HotWax Systems*
>> Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010
>> Cell phone: +91 96697-50002
>>
>
>

Reply via email to