Re: svn commit: r1832662 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

[Michael Brohl]

Hi Jacques,




Regards,

Michael


Am 03.06.18 um 10:28 schrieb Jacques Le Roux:

I would *always* prefer a Jira, patch and discussion *first* before a commit in these core areas of the application.

Hi Taher,

Thanks for asking.







I'll change that

Jacques


Le 03/06/2018 à 00:33, Taher Alkhateeb a écrit :

I created the Jira afterwards and then updated the commits comments. More a pattern to prevent security disclosures. I must say in this case not of much use, anyway I prefer to keep this habit. I called session.invalidate() because at this stage we already have a session. Actually an org.apache.catalina.session.StandardSessionFacade, Tomcat handles it. So request.getSession() does not create one. But I had a new look and I can do better. I was unaware of request.changeSessionId() which is better here since I only need to change the session id.

I can't find the JIRA reference for this commit, can you place share a
JIRA if it exists? Also, I'm not sure why you're calling
session.invalidate()? Doesn't request.getSession() already assign a
new session depending on client settings?

On Fri, Jun 1, 2018 at 10:37 AM,  <jler...@apache.org> wrote:

Author: jleroux
Date: Fri Jun  1 07:37:27 2018
New Revision: 1832662

URL: http://svn.apache.org/viewvc?rev=1832662&view=rev
Log:

  audit tool "IBM Security AppScan Enterprise , Version : 9.0.3.7"


(ultimately put in cookie).

Only do when really signing in to avoid unnecessary calls

new on each request, not a good choice on client side!



Modified:
ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

Fixes a session fixation security issue discovered by a client with the security Prevents the session fixation by making Tomcat generate a new jsessionId Though if the client has disabled the use of cookies, then a session will be Modified: ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java?rev=1832662&r1=1832661&r2=1832662&view=diff ============================================================================== --- ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java (original) +++ ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java Fri Jun  1 07:37:27 2018

@@ -328,6 +328,14 @@ public class LoginWorker {
       */

          HttpSession session = request.getSession();
+

+        if (!session.isNew()) {  // Only do when really signing in.

+            session = request.getSession(true);

+        }
+

          String username = request.getParameter("USERNAME");
          String password = request.getParameter("PASSWORD");

      public static String login(HttpServletRequest request, HttpServletResponse response) { +        // Prevent session fixation by making Tomcat generate a new jsessionId (ultimately put in cookie). +            session.invalidate(); // If the client has disabled the use of cookies, then a session will be new on each request, not a good choice on client side! +            UtilHttp.setInitialRequestInfo(request); // We need to put that in place again           Delegator delegator = (Delegator) request.getAttribute("delegator");

smime.p7s
Description: S/MIME Cryptographic Signature