[ https://issues.apache.org/jira/browse/OFBIZ-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12548282 ]
Adrian Crum commented on OFBIZ-1485: ------------------------------------ Jonathon, Thank you for taking the time to review the code. If you look closely at the existing code, FlexibleProperties contributes nothing to UtilProperties. It may have additional methods, but they aren't being used anywhere. UtilProperties treats FlexibleProperties as a generic Properties object. I understand a Map is less restrictive than a Properties object - that's why the methods that returned Properties objects still do so. In addition, we have new methods that return Maps - and those Maps use Generics to enforce the Key is String and Value is String constraints. Building a custom Properties class around a FastMap is an interesting idea, but I don't think it's necessary. If a piece of code MUST have a Properties object, one can be constructed from a FastMap by using the Properties.putAll(...) method. > UtilProperties - The Next Generation > ------------------------------------ > > Key: OFBIZ-1485 > URL: https://issues.apache.org/jira/browse/OFBIZ-1485 > Project: OFBiz > Issue Type: Improvement > Components: framework > Reporter: Adrian Crum > Priority: Minor > Attachments: props_tng.patch > > > Improve the UtilProperties class. Details in comments. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.