Hi Nicolas, all

Maybe before we take a decision on this, we should first investigate a
few things. For example:
- How fast are the tests?
- How stable and consistent are they?
- How much resources does it consume (memory, etc ...)

Then, based on the above information, perhaps it would be easier to
decide if we want to include or exclude them from testIntegration. I
agree with you in concept, these tests are more like functional tests
and less like integration tests. However, if we find them fast, light,
and stable enough, then I don't see a reason why not to include them.

So my recommendation is to seek the above information, and then take
one of following decisions:
- Include them in testIntegration
- Include them in a separate plugin like you suggested
- Include a new gradle task and alter the test container to have a
separate patch for testing functional tests
- Something else ...

My 2 cents
On Thu, Aug 23, 2018 at 3:08 PM Nicolas Malin <nicolas.ma...@nereide.fr> wrote:
>
> Hello,
>
> I appreciate the work done around the sanity test, just I have a doubt
> about integrate them to testIntegration target.
>
> I'm more in favor to ensure that we have unit test on service involve by
> these sanity test, and if you want offer the possibility to run it by an
> automation like selenium, load it as plugin.
>
> Nicolas
>
>
> On 23/08/2018 13:08, Sanjay Yadav wrote:
> > Yes, Taher. It will be in Selenium.
> >
> > Moving this email thread to the dev mailing list. Thanks!
> >
> > Best Regards,
> >
> > *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> > HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> > <http://www.hotwaxsystems.com/>
> > 80, Scheme No. 78, Indore, M.P. 452010, India
> > Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> > <https://www.linkedin.com/in/sanjay-yadav/>
> >
> >
> >
> > ---------- Forwarded message ---------
> > From: Taher Alkhateeb <slidingfilame...@gmail.com>
> > Date: Thu, Aug 23, 2018 at 2:39 PM
> > Subject: Re: OFBiz Sanity Test Automation
> > To: <u...@ofbiz.apache.org>
> >
> >
> > Hello, is this going to be implemented in Selenium? If yes then
> > perhaps we should move this discussion to dev@ to make sure we get
> > this right. Functional tests might be very slow and so we might need
> > to decide whether to include these tests by default with the
> > "testIntegration" task for example.
> > On Thu, Aug 23, 2018 at 11:53 AM Rishi Solanki <rishisolan...@gmail.com>
> > wrote:
> >> +1, and yes go for 17.12 + Trunk. And first pick the 17.12 as it would be
> >> stable compare to trunk,
> >>
> >>
> >> --
> >> Rishi Solanki
> >> Sr Manager, Enterprise Software Development
> >> HotWax Systems Pvt. Ltd.
> >> Direct: +91-9893287847
> >> http://www.hotwaxsystems.com
> >> www.hotwax.co
> >>
> >>
> >> On Thu, Aug 23, 2018 at 2:09 PM Sanjay Yadav <
> > sanjay.ya...@hotwaxsystems.com>
> >> wrote:
> >>
> >>> Yes, Michael:).Thanks.
> >>>
> >>> Thanks, Jacques.
> >>>
> >>> Best Regards,
> >>>
> >>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> >>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> >>> <http://www.hotwaxsystems.com/>
> >>> 80, Scheme No. 78, Indore, M.P. 452010, India
> >>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> >>> <https://www.linkedin.com/in/sanjay-yadav/>
> >>>
> >>> On Wed, Aug 22, 2018 at 12:55 PM Michael Brohl <michael.br...@ecomify.de
> >>> wrote:
> >>>
> >>>> +1 Sanjay,
> >>>>
> >>>> as I mentioned in
> >>>>
> >>>>
> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test?focusedCommentId=71014351#comment-71014351
> >>>> ;-)
> >>>>
> >>>> Regards,
> >>>>
> >>>> Michael Brohl
> >>>> ecomify GmbH
> >>>> www.ecomify.de
> >>>>
> >>>>
> >>>> Am 22.08.18 um 08:22 schrieb Sanjay Yadav:
> >>>>> Hello All,
> >>>>>
> >>>>> I am planning to automate below sanity test script. Please feel
> > free to
> >>>>> share your thoughts.
> >>>>> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Sanity+Test
> >>>>>
> >>>>> Which OFBiz version I should target?
> >>>>> Do I need to create a JIRA ticket before starting on it?
> >>>>>
> >>>>> Best Regards,
> >>>>>
> >>>>> *Sanjay Yadav* | Manager, Enterprise Quality Assurance
> >>>>> HotWax Commerce <http://www.hotwax.co/> by HotWax Systems
> >>>>> <http://www.hotwaxsystems.com/>
> >>>>> 80, Scheme No. 78, Indore, M.P. 452010, India
> >>>>> Mobile Phone: 787 918 8830 | Linkedin: Sanjay-Yadav
> >>>>> <https://www.linkedin.com/in/sanjay-yadav/>
> >>>>>
> >>>>
> >>>>
>

Reply via email to