Hi Pierre, All,
If we consider inter components labels dependencies, I fear several (most?)
applications components are inter dependent.
For instance looking for "uiLabelMap.Manufacturing"(which does not guarantee to find all Manufacturing labels since it's a convention and not all
labels are such prefixed) in all files you find these applications use at least one:
* accounting
* order
* product
If you look for ManufacturingUiLabels (more relevant) in all file, the same
applications use at least one.
In comment there, Pierre you reported a dependency from accounting to
manufacturing and we added it.
But we have no dependencies shown for order, nor product, to manufacturing on
https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies
Now I have a question: should we consider labels dependencies in this graph and complete it? I don't think so, the graph which is already loaded with
links would become illegible (maybe the underline Digraph code would still be useful though).
Remains that we have a lot of inter components labels dependencies. There are 2
possible views on this:
1. Anyway we don't want to separate the applications and they will forever
stand together. So we just remove the links between application in the
graph above with the comments (tempting hè :))
2. We still want to separate the applications (one day...) and they we need to
take in consideration of kind of dependencies.
I believe we still want to separate the applications, notably those who are more peripherals, like HR, marketing. Those could be extracted as plugins.
Pierre even mentioned manufacturing, where I don't agree, but that could be discussed.
A simple solution for labels is to extract those which are inter-components and
put them in the applications using them or common if several use them
What do you think?
Jacques
Le 04/10/2018 à 14:15, Jacques Le Roux a écrit :
Thanks Pierre,
I'll have a closer look. If it's only labels that can be "easily" fixed.
Jacques
Le 04/10/2018 à 14:05, Pierre Smits a écrit :
Hi Jacques, all,
Doing a search in your favourite IDE on 'manufacturing' reveals all
references. A cursory review in mine showed a lot of inclusions of the
ManufacturingUiLabels.
Best regards,
Pierre Smits
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer
On Thu, Oct 4, 2018 at 10:31 AM Jacques Le Roux <
[email protected]> wrote:
Hi Pierre,
Without explanation about the exact dependency from Accounting to
Manufacturing I'll remove the comments.
It would really help to have even just an idea of the kind of this/se
dependeny/ies if it's/they are still existing. Then, if they still exist, a
OFBIZ-3500 subtask could be created/
All this because I'd like to clarify the graph and remove component
dependencies when they were just due to data being in each component and
now in
https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk/applications/datamodel/data
TIA for your help
Jacques
Le 21/09/2018 à 16:20, Jacques Le Roux a écrit :
Hi Pierre,
Could you please clarify why we still need to keep these comment now that
the dependencies are in the graph.
Notably the comment you made
This diagram is missing:
- a dependency of Accounting on Manufacturing,
would be interesting if there was an explanation of the exact dependency
from Accounting on Manufacturing. If it's not data dependencies, which are
now resolved for applications.
For order on accounting code dependency, I believe it's impossible to
remove. Those need to be interconnected (eg when you send an order you need
to create an invoice).
Thanks
Jacques
Le 08/09/2018 à 11:20, Pierre Smits a écrit :
It would be better to let the comments stay until all undesirable
dependencies are removed and ticket OFBIZ-3500 has been closed.
Best regards,
Pierre Smits
Apache Trafodion <https://trafodion.apache.org> <https://trafodion.apache.org>,
Vice President
Apache Directory <https://directory.apache.org> <https://directory.apache.org>,
PMC Member
Apache Incubator <https://incubator.apache.org> <https://incubator.apache.org>,
committer
*Apache OFBiz <https://ofbiz.apache.org> <https://ofbiz.apache.org>,
contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org> <https://steve.apache.org>, committer
On Sat, Sep 8, 2018 at 11:15 AM, Deepak Dixit <[email protected]>
<[email protected]>
wrote:
Hi Jacques,
I think we are good and can delete the comments.
Thanks & Regards
--
Deepak Dixit
On Mon, Aug 20, 2018 at 12:22 PM, Jacques Le Roux
<[email protected]> wrote:
Great, thanks Deepak
Jacques
Le 20/08/2018 à 06:20, Deepak Dixit a écrit :
Hi Jacques,
I'll check and share details ASAP.
On Sun, Aug 19, 2018 at 3:57 PM, Jacques Le Roux <[email protected]
<mailto:[email protected]> <[email protected]>>
wrote:
Hi Deepak,
Before I remove all the comments at https://cwiki.apache.org/confl
uence/display/OFBIZ/Component+and+Component+Set+Dependencies
<https://cwiki.apache.org/confluence/display/OFBIZ/Component
+and+Component+Set+Dependencies> <https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies> and remove in the
graph the dependency
from the
accounting to workeffort introduced by r1710178 ;
<http://svn.apache.org/viewvc?view=revision&revision=1710178>
<http://svn.apache.org/viewvc?view=revision&revision=1710178>
could you please confirm there is no longer data dependencies from
accounting to workeffort since we moved the data to
applications/datamodel?
I guess there should not be and we should try to clean this graph
for
maybe other such dependencies (only because of data) now that this step
is
almost complete (after Rishi's future effort on "Shipping data
duplicated
<https://lists.apache.org/thread.html/f5118a1cd378aed4e5af7c
904fc026f36ba5c7aa78862f72d813348b@%3Cdev.ofbiz.apache.org%3E>
<https://lists.apache.org/thread.html/f5118a1cd378aed4e5af7c904fc026f36ba5c7aa78862f72d813348b@%3Cdev.ofbiz.apache.org%3E>" thread)
Thanks
Jacques
