+1, Its good to make sendFrom mandatory for sendMail service.
Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Fri, Feb 22, 2019 at 9:41 PM Benjamin Jugl <benjamin.j...@ecomify.de> wrote: > Hello fellow developers, > > I just checked my open Jira-Issues and look, what I found: > > OFBIZ-10706 <https://issues.apache.org/jira/browse/OFBIZ-10706> ! > > In Short: > I found an NPE caused by /EmailServices.sendMail/ and provided a Patch > that expanded the /sendMailOnePartInterface/ to have sendFrom mandatory, > just as sendTo. > > The alternative solution would have been, to catch the NPE and try to > send the Email without a sendFrom, no matter what. > > Jacques Le Roux asked me to ask you, if this change might disrupt custom > projects of you. So please give me/us notice, if this is the case. > >
