Hello Jacques, Jacques Le Roux <jacques.le.r...@les7arts.com> writes:
> Did you report to Apache Commons DBCP? Else should we not? No I didn't report. I think it would be fine to report the issue that ‘ManagedDataSource’ should declare more specific exceptions than ‘Exception’ for the ‘close’ method to allow the compiler to check that no ‘InterruptedException’ are thrown. > Le 26/02/2019 à 11:09, jler...@apache.org a écrit : >> Author: jleroux >> Date: Tue Feb 26 10:09:40 2019 >> New Revision: 1854366 >> >> URL: http://svn.apache.org/viewvc?rev=1854366&view=rev >> Log: >> Improved: no functional change >> >> Fixes a typo in comment. I checked it's still not implemented in last DBCP >> (2.6.0) >> >> Modified: >> >> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java >> >> Modified: >> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java >> URL: >> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java?rev=1854366&r1=1854365&r2=1854366&view=diff >> ============================================================================== >> --- >> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java >> (original) >> +++ >> ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/connection/DebugManagedDataSource.java >> Tue Feb 26 10:09:40 2019 >> @@ -69,7 +69,7 @@ public class DebugManagedDataSource<C ex >> // Ensures that the close() method does not throw an >> InterruptedException >> // to conform to the AutoCloseable interface. >> - // This is fixing what should be down in >> org.apache.commons.dbcp2.PoolingDataSource. >> + // This is fixing what should be done in >> org.apache.commons.dbcp2.PoolingDataSource. >> @Override >> public void close() throws SQLException, RuntimeException { >> try { Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
