Hi Pawan
Sounds good, just one point to be careful of:
maxRetry = 0
if (!maxRetry) {
// Not set, use a default
maxRetry = -1
}
Because groovy evaluates zero to be false, it wouldn't be possible to set
maxRetry to zero. So it's best not to use groovy truth for null-checks on
numbers in some cases. I thought it was worth mentioning since there's a
higher risk of making this mistake when making changes in bulk.
Regards
Scott
On Thu, 16 May 2019 at 00:29, Pawan Verma <pawan.ve...@hotwaxsystems.com>
wrote:
> Hello Devs,
>
> As we all know, Groovy is a powerful language with great built-in
> functions. Groovy Truth[1] is one of them, which is not used properly in
> our code base. We have used UtilValidate Class to validate arguments for
> Empty or NotEmpty, which can easily be done in groovy with built-in
> functionality.
>
> Current Code: if (UtilValidate.isNotEmpty(locations)) { ... }
>
> Groovy Built-in Code: if (locations) { ... }
>
> IMO, We should use this Groovy Truth feature instead of UtilValidate Class.
> Please let me know your thoughts on this. Thanks!
> [1] - http://groovy-lang.org/semantics.html#Groovy-Truth
>
> --
> Kind Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
>
