[
https://issues.apache.org/jira/browse/OFBIZ-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549743
]
Jacques Le Roux commented on OFBIZ-1393:
----------------------------------------
I would just change
if((defaultConfigOptionId != null) && (defaultConfigOptionId.length() > 1))
for
if (UtilValidate.isNotEmpty(defaultConfigOptionId))
and please put space around operators, like in
if (defaultConfigOptionId.compareToIgnoreCase(currentConfigOptionId)==0 ){
also a tab in
+ <field name="defaultConfigOptionId" type="id"></field>
should replaced by 4 spaces
Else everything looks good ;o)
> Need a better way to specify the default item configuration
> -----------------------------------------------------------
>
> Key: OFBIZ-1393
> URL: https://issues.apache.org/jira/browse/OFBIZ-1393
> Project: OFBiz
> Issue Type: Improvement
> Components: product
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Chris Lombardi
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: ofbiz-1393-2.patch
>
>
> Currently, setDefaultConfig in ProductConfigWrapper assumes the default is
> the first ProductConfigOption. I would like to be able to set up different
> products that shared a set of ProductConfigOptions yet allow for a different
> default ProductConfigOption.
> I don't yet have an opinion on how I can best implement this and my Data
> Model Resource Book is in the mail. Does anyone have any thoughts or
> preferences?
> Here's how it's currently implemented:
> public void setDefaultConfig() {
> resetConfig();
> for (int i = 0; i < questions.size(); i++) {
> ConfigItem ci = (ConfigItem)questions.get(i);
> if (ci.isMandatory()) {
> if (ci.getOptions().size() > 0) {
> ConfigOption co = (ConfigOption)ci.getOptions().get(0);
> // default is first option
> co.setSelected(true);
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
