Ok, I understand now :)
I take a wrong way to focus on gradlew as immutable file.
I proposed a patch on OFBIZ-10145 [1] [2] to update it and keep the same
build process.
Nicolas
[1] https://issues.apache.org/jira/browse/OFBIZ-10145
[2]
https://issues.apache.org/jira/secure/attachment/12970646/OFBIZ-10145-gradlew.patch
On 31/05/2019 08:59, Jacques Le Roux wrote:
+1 pour Maurice (as my question was wondering)
Jacques
Le 31/05/2019 à 00:02, Mathieu Lirzin a écrit :
Nicolas Malin <nicolas.ma...@nereide.fr> writes:
On 30/05/2019 13:04, Mathieu Lirzin wrote:
Nicolas Malin <nicolas.ma...@nereide.fr> writes:
hmm not, I just control that if we haven't gradlew we init it.
Your remark just alert me that I forget to set the gradlew on .ignore
I am confused. Are you proposing to add "gradlew" in the “./gitignore”
and “./hgignore” files in the framework repository? If not what is
“.ignore”?
Tu pinalles Maurice :)
You right, the better syntax would be ./*ignore so yes complete
./gitignore and ./hgignore
I wasn't nitpicking on your spelling, I was just checking that I was I
was understanding you correctly before disagreeing. :-)
IMO “./gradlew” should definitely be kept in our Version Controlled
System (VCS) in order to follow Gradle recommendations and avoid
specific build instructions.
The requirement of not distributing “gradle-wrapper.jar” in OFBiz
releases should only impact the build process of the release archives
and *not* the build process of the VCS branches.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ofbiz.apache.org
For additional commands, e-mail: dev-h...@ofbiz.apache.org
