Done.
Here we go, there were:
Unapproved Licenses:
1.
/home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/accounting/groovyScripts/test/AutoAcctgInvoiceTests.groovy
2.
/home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/order/groovyScripts/test/OrderTests.groovy
3.
/home/buildslave/slave/ofbizTrunkFrameworkRat/build/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPriority.java
4.
/home/buildslave/slave/ofbizTrunkFrameworkRat/build/plugins/msggateway/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java
1. Patch Vivek Singh Bisen, commit Suraj
2. Initial Pach Pawan Verma, commit Suraj
3. Scott
4. Patch Pritam Kute, commit Rishi. Went unnoticed by Mathieu later but that
does not count, it's harder to spot then but with RAT's help. The RAT
name was well chosen, reminds me Jack Nicholson in "The Departed" :)
That's all for the shame today :D
Jacques
Le 03/06/2019 à 13:07, Jacques Le Roux a écrit :
Damn, I hope I'm not one of them ;)
Le 03/06/2019 à 10:04, Scott Gray a écrit :
I hope you'll name the reviewers that missed them as well :-)
On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <jacques.le.r...@les7arts.com>
wrote:
OK, I'll do it in a week if nobody beats me on it.
But I'll name those that should have done it before :p
Jacques
Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
Hi Committers,
Please guys make an effort:
https://ci.apache.org/projects/ofbiz/rat-output.html
I normally do it (add missing licences) but the RAT build was off for
months and they piled up
(OK now as it specifically depends on lares_ubuntu Buildbot server:
https://issues.apache.org/jira/browse/INFRA-18500)
You should be able to recognise your own commits, and it's better for
you to learn and remember ;)
Thanks
Jacques
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@ofbiz.apache.org
For additional commands, e-mail: dev-h...@ofbiz.apache.org
