Thanks Jaques, As we are already open ticket to move from svn to git, so I think we don;t need to take care of this request. Git has its own commit notification template. https://issues.apache.org/jira/browse/INFRA-19308
Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Fri, Oct 18, 2019 at 3:11 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Opinions may vary, I don't think we need a vote for that, lazy consensus > should be enough (who prefers a litany of file names over a clear subject > for > commit notifications?) > > We can already create an Infra Jira, before it's implemented possible > other opinions would have enough time to express > > Thanks > > Jacques > > Le 18/10/2019 à 11:03, Deepak Dixit a écrit : > > Thanks Jaques, So what is next? > > Do we need to initiate vote for this change? > > > > Thanks & Regards > > -- > > Deepak Dixit > > ofbiz.apache.org > > > > > > On Fri, Oct 18, 2019 at 1:05 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > >> Hi Deepak, Pranay, > >> > >> That could be a good thing, and is indeed in the hand of Infra. > >> > >> These are related, I guess INfra is aware anyway: > >> > >> https://issues.apache.org/jira/browse/SVN-2499 > >> http://manpages.ubuntu.com/manpages/xenial/man3/SVN::Notify.3pm.html > >> > >> > https://stackoverflow.com/questions/501692/easiest-best-way-to-set-up-svn-commit-emails > >> > >> Thanks > >> > >> Jacques > >> > >> Le 18/10/2019 à 08:28, Deepak Dixit a écrit : > >>> Nice thought Pranay, for this we need to check with infra team. > >>> If we all agree we can discuss this thing with infra team. > >>> > >>> > >>> Thanks & Regards > >>> -- > >>> Deepak Dixit > >>> ofbiz.apache.org > >>> > >>> > >>> On Thu, Oct 17, 2019 at 6:16 PM Pranay Pandey < > >>> pranay.pan...@hotwaxsystems.com> wrote: > >>> > >>>> Hello, > >>>> > >>>> With my limited knowledge in this area, I wanted to ask for this > >>>> possibility. Can we do some configuration changes so that an SVN > commit > >>>> notification is having a subject line(Commit Title) instead of a list > of > >>>> files changed in that commit? > >>>> E.g. > >>>> For this commit IMO if the subject line reads as given below can be > >>>> helpful: > >>>> ============================ > >>>> svn commit: r1868549 - release17.12 - Applied fix from plugins for > >>>> revision: 1868545 > >>>> ============================ > >>>> > >>>> and Original commit to trunk commit notification can read something > >> like: > >>>> ============================ > >>>> svn commit: r1868545 - Fixed: EditExample always update status, > because > >>>> current Status not shown > >>>> (OFBIZ-11230) > >>>> ============================ > >>>> > >>>> and then rest can be left as is in the body which is already there. > Can > >> we > >>>> do this? Is it possible? Should we do it? > >>>> > >>>> Best regards, > >>>> Pranay Pandey > >>>> > >>>> > >>>> On Thu, Oct 17, 2019 at 5:50 PM <jler...@apache.org> wrote: > >>>> > >>>>> Author: jleroux > >>>>> Date: Thu Oct 17 12:20:29 2019 > >>>>> New Revision: 1868549 > >>>>> > >>>>> URL: http://svn.apache.org/viewvc?rev=1868549&view=rev > >>>>> Log: > >>>>> "Applied fix from plugins for revision: 1868545" > >>>>> > >> ------------------------------------------------------------------------ > >>>>> r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | > 16 > >>>>> lignes > >>>>> > >>>>> Fixed: EditExample always update status, because current Status not > >> shown > >>>>> (OFBIZ-11230) > >>>>> > >>>>> In the EditExample Form, the drop-down is populates with the Valid > >> change > >>>>> status > >>>>> only. So current status is not in the list and the status print in > the > >>>>> drop-down > >>>>> is the next authorized. I want to modify exampleName or exampleType, > I > >> go > >>>>> to > >>>>> editExample and change what I want and validate. The problem is > status > >> is > >>>>> also > >>>>> changed! > >>>>> > >>>>> There are 12 other same or similar cases. For the first of them (in > >>>>> FinAccount) > >>>>> there is the same bug: when I change FinAccount Name, status change > >> too. > >>>>> If I > >>>>> add current="first-in-list" in the tag drop-down it works > >>>>> > >>>>> jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong > >> fix > >>>>> Thanks: Oliver for the analysis and the fix > >>>>> > >> ------------------------------------------------------------------------ > >>>>> Modified: > >>>>> ofbiz/ofbiz-plugins/branches/release17.12/ (props changed) > >>>>> > >>>>> > >> > ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml > >>>>> Propchange: ofbiz/ofbiz-plugins/branches/release17.12/ > >>>>> > >>>>> > >> > ------------------------------------------------------------------------------ > >>>>> Merged /ofbiz/ofbiz-plugins/trunk:r1868545 > >>>>> > >>>>> Modified: > >>>>> > >> > ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml > >>>>> URL: > >>>>> > >> > http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml?rev=1868549&r1=1868548&r2=1868549&view=diff > >> > ============================================================================== > >>>>> --- > >>>>> > >> > ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml > >>>>> (original) > >>>>> +++ > >>>>> > >> > ofbiz/ofbiz-plugins/branches/release17.12/example/widget/example/ExampleForms.xml > >>>>> Thu Oct 17 12:20:29 2019 > >>>>> @@ -198,7 +198,8 @@ under the License. > >>>>> </drop-down> > >>>>> </field> > >>>>> <field name="statusId" use-when="example!=null" > >>>>> title="${uiLabelMap.CommonStatus}" required-field="true"> > >>>>> - <drop-down allow-empty="false" > >>>>> current-description="${currentStatus.description}"> > >>>>> + <drop-down allow-empty="false" current="first-in-list" > >>>>> current-description="${currentStatus.description}"> > >>>>> + <option key="${currentStatus.statusId}" > >>>>> description="${currentStatus.description}"/> > >>>>> <entity-options > >> entity-name="StatusValidChangeToDetail" > >>>>> key-field-name="statusIdTo" description="${transitionName} > >>>>> (${description})"> > >>>>> <entity-constraint name="statusId" > >>>>> env-name="example.statusId"/> > >>>>> </entity-options> > >>>>> > >>>>> > >>>>> >
