Le 28/11/2019 à 11:16, Mathieu Lirzin a écrit :
Hello Jacques,
Jacques Le Roux <[email protected]> writes:
OK, now we need to agree about tasks.checkstyleMain.maxErrors in build.gradle:
https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1041/steps/shell_1/logs/stdio
Locally with trunk and plugins HEAD I get
Checkstyle files with violations: 1039
Checkstyle violations by severity: [error:37854]
Probably because you have an extra plugin installed and/or an different
version of the official plugins.
Nope, I use the same than in Buildbot config: pullAllPluginsFromSource.
To be sure it was HEAD, before running check I made an svn up. And I have no
extra plugins.
I guess it's a Windows thing. Because on my Ubuntu VM, on the same machine, I
get the same number of errors than with Buildbot
Moreover, when I use Git Bash (ie a tool to run Bash on Windows) I get the same
than with plain Windows, maybe because of EOLs
Anyway I now know that's there is a make difference and I rarely run the check
task.
I still wonder why it's not, as in Buildbot
Checkstyle files with violations: 1039
Checkstyle violations by severity: [error:37787]
With latest trunk from both framework/plugins repository I get the same
number on my machine.
And why we have tasks.checkstyleMain.maxErrors = 37776 in code.
37787 - 37776 = 11 linting errors
This is the number of linting errors introduced by either Pawan Verma or
Nicolas Malin since commit a521de9ad8a0b5a0f9ceadab348c46d7961ff89a that
remains not fixed.
Could someone enlighten me?
Does it help ? :-)
Yes, thanks Mathieu
Jacques
