Effectively, good point to make more attention on the future.

I'm not sure that I can amend this commit without make a push force after, so I prefer to keep this error instead generate more inconvenient.

thanks also Jacques for the following issue :)

Nicolas

On 08/12/2019 09:58, Jacques Le Roux wrote:
Le 07/12/2019 à 16:06, Mathieu Lirzin a écrit :
Hello Nico,

nma...@apache.org writes:

commit 071a74238b4d53fb95ffd214e0e68e55840a28e3
Author: Nicolas Malin <nicolas.ma...@nereide.fr>
AuthorDate: Fri Dec 6 21:29:01 2019 +0100

     Fixed: Fix missing else during previous refactoring
     (OFBIZ-11253)
     When you rendering for with auto-field-entity on edit mode, indicator field has been override by text field.      Fix also two error on source field type set to FieldInfo.SOURCE_AUTO_SERVICE instead of FieldInfo.SOURCE_AUTO_ENTITY
          Thanks to Olivier Heintz to inform on the regression.
---
In your following commits, it would be nice if you could add an empty
line between the summary and body of your commit messages.

This will help ‘git log --oneline’ to be more helpful by not showing the
details of the commit.

Thanks.
Yep, did OFBIZ-11298 for that :)

Jacques


Reply via email to