Hello team, Recently we are working on a major refactoring task of minilnag to groovy conversion, which is commendable. I would like to add following points to be taken into consideration while doing the exact changes in the service:
- Check and think of possible conversion to entity-auto. - Handle service error responses, in xml usually we skip it. It would be great if while conversion if any service is called, its error response should be effectively handled. Like in a single line: serviceResult = run service: "createCustomer", with: parameters if (!ServiceUtil.isSuccess(serviceResult)) return error(serviceResult.errorMessage) - Avoid unnecessary declaration of variables and the same 'serviceResult' map can be re-used in case of multiple service calls inside the same service. IMO, these are very small best practices that can directly be taken care of while conversion, will improve code quality. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
