Hi Jacques, I think *check styles* plugin is important for us and we should think of introducing a pre-commit hook that checks only for the staged changes. This will help developers to know about the lint issues before the commit itself.
Some reference I found that achieves the above case. Though I didn't try any of these solutions. https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/ What do you think? Thanks and Regards, Aditya Sharma On Sat, May 23, 2020 at 6:44 PM Pawan Verma <pawan.ve...@hotwaxsystems.com> wrote: > Hi Jacques, > > I care for the *checkstyle* issues but I also feel we should abandon it. > > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Sat, May 23, 2020 at 6:08 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Ha wait I confused w/ something else. > > > > Aas I said when starting this thread > > > > "this is a *checkstyle* issue. It's not clear to me why it happened." > > > > Currently BuildBot makes erratic exceptions trying to pull. I have > created > > for that (and just updated) > > https://issues.apache.org/jira/browse/INFRA-20303 > > > > So it's maybe not only your commit which increased the style errors... > > > > Unfortunately in this case, as it's then difficult to know form where > > comes the errors (they can be cumulated commit after commit), the easier > > issue > > is to set tasks.checkstyleMain.maxErrors to the last reported errors :/ > > > > Now I have also mentioned in the 1st msg of this thread: > > > > "Also I begin to wonder if the community really cares about > > *checkstyle* issues..." > > > > I mean we could maybe abandon it since it seems I'm the only one to > care... > > > > HTH > > > > Jacques > > > > Le 23/05/2020 à 14:23, Jacques Le Roux a écrit : > > > Thanks Suraj! > > > > > > Jacques > > > > > > Le 23/05/2020 à 14:04, Suraj Khurana a écrit : > > >> Hello team, > > >> > > >> All tests passed on my local machine. > > >> > > >> I used: ./gradlew testIntegration > > >> > > >> -- > > >> Best Regards, > > >> Suraj Khurana > > >> Senior Technical Consultant > > >> > > >> > > >> On Sat, May 23, 2020 at 5:17 PM <build...@apache.org> wrote: > > >> > > >>> The Buildbot has detected a new failure on builder > > >>> ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full > > details are > > >>> available at: > > >>> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1396 > > >>> > > >>> Buildbot URL: https://ci.apache.org/ > > >>> > > >>> Buildslave for this Build: asf947_ubuntu > > >>> > > >>> Build Reason: downstream > > >>> Build Source Stamp: [branch trunk] > > 8bdb6c99856fd4ae17a95ccb0f661a256caaab13 > > >>> Blamelist: Suraj Khurana < > > 64310724+surajkhur...@users.noreply.github.com>,Suraj > > >>> Khurana <sur...@apache.org> > > >>> > > >>> BUILD FAILED: failed shell_2 > > >>> > > >>> Sincerely, > > >>> -The Buildbot > > >>> > > >>> > > >>> > > >>> > > >
