[ 
https://issues.apache.org/jira/browse/OFBIZ-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551048
 ] 

David E. Jones commented on OFBIZ-1442:
---------------------------------------

There are certainly trade-offs, but I still think that the combined files are 
better and easier to maintain and manage than separate ones.

For Christian's points:

1. the XML files will get pretty large but the processing time should still 
scale linearly; if not there is a bug somewhere

2. I guess this is a matter of perspective, but if I were adding a new language 
it would be nice to not have to have multiple files open and either jump around 
to those files to get the original labels or to be forced to use some sort of 
tool to manage the multiple files; also having multiple files to review and add 
to increases the chances of getting a property key wrong (which has happened a 
few times), and even worse on the maintenance side it makes it really prone to 
inconsistent property sets in different files unless a tool is used to help 
keep them consistent, and this is currently a bigger problem in ofbiz

3. if someone makes changes to UTF characters in a non-UTF-aware editor 
wouldn't the diff on the commit be huge, and result in lots of unintended line 
changes that would be fairly easy to spot?



> Add ability to use XML property files for locale-specific properties
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-1442
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1442
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>            Reporter: Adrian Crum
>            Priority: Minor
>         Attachments: xml_props.patch, xml_props.patch, xml_props_demo.patch
>
>
> As per discussion on the dev mailing list, implement XML property files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to