Hi all,
I looked at the patch and have some additional questions about these
changes.
1. There are some added <span> elements I do not fully understand in
the HtmlFormMacroLibrary.ftl template. Could you explain why they
are necessary for the given proposition?
2. It feels like using a Flexbox layout would be more appropriate for a
modern look and feel. Is there a reason you implemented a CSS Grid
instead of the as far as I know most commonly used system (see
Bootstrap for example)? I think when modernizing the current user
interface we would benefit more from a Flexbox implementation.
However, I do understand the need for modernization in the current user
interface.
Best regards,
Ingo
Am 26.01.21 um 17:59 schrieb Nicolas Malin:
Hello James,
I'm a little bit confused with your proposition, It's a direct conflict
with the separation between the model of a form and the way to rendering
it throw the theme.
If you want create a specific form for different display case maybe
check the extend logic OFBIZ-11335
<https://issues.apache.org/jira/browse/OFBIZ-11335>[1]
My feel is keep more simple as possible the form type code.
Nicolas
[1] https://issues.apache.org/jira/browse/OFBIZ-11335
On 26/01/2021 14:32, James Yong wrote:
Hi all,
Planning to add a new form widget type i.e. single_css-grid-layout.
This new type allows Single Form Widget to be layout with CSS Grid, instead of
table.
Created OFBIZ-12162 with patch for it.
Regards,
James
