Jacques, The failure is not due to the inclusion of the SystemProperty record in seed data. It is due to a unexpected result when testInvoicePerShipment is called with product="GZ-1000" and invoicePerShipment="N". And the same happens in the same test with product="GZ-1000" and invoicePerShipment="Y".
Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since 2008 (without privileges) Proud contributor to the ASF since 2006 *Apache Directory <https://directory.apache.org>, PMC Member* On Mon, Dec 13, 2021 at 11:38 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks guys, > > With the help of Pierre, I found that it's due to > https://github.com/apache/ofbiz-framework/pull/392/files > > Exactly to > > <SystemProperty systemResourceId="accounting" > systemPropertyId="create.invoice.per.shipment" systemPropertyValue="Y" > description="create invoice per shipment. Options: = Y (Invoice per > shipment), N (Invoice per order)"/> > > As the test name says testInvoicePerShipmentSetFalse > > The alternatives are: > > 1. Revert the PR (would allow to go on with INFRA-22279) > 2. Just comment out the property above (would allow to go on with > INFRA-22279) > 3. Discuss if we want to use invoice per shipment by default (I guess it > has been already done, if not several times) > > For now I decide to use 2 as it's the easiest way to go on with INFRA-22279 > > Jacques > > Le 13/12/2021 à 10:47, Pierre Smits a écrit : > > On my Mac the testInvoicePerShipmentSetFalse fails too, giving > > > > assert UtilValidate.isEmpty(invoices) | | false > [['orderItemSeqId':'00001', > >> 'amount':15.99, 'quantity':1.000000, 'statusId':'INVOICE_READY', > >> 'orderId':'WSCO10020', 'itemIssuanceId':'10020', 'invoiceId':'CI1', > >> 'invoiceItemSeqId':'00001', 'shipmentReceiptId':null]] > >> > >> Assertion failed: > >> > >> assert UtilValidate.isEmpty(invoices) > >> | | > >> false [['orderItemSeqId':'00001', 'amount':15.99, 'quantity':1.000000, > >> 'statusId':'INVOICE_READY', 'orderId':'WSCO10020', > >> 'itemIssuanceId':'10020', 'invoiceId':'CI1', 'invoiceItemSeqId':'00001', > >> 'shipmentReceiptId':null]] > >> > >> at > >> > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:415) > >> at > >> > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:670) > >> at > >> > org.apache.ofbiz.accounting.InvoicePerShipmentTests.testInvoicePerShipmentSetFalse(InvoicePerShipmentTests.groovy:154) > >> at > >> > org.apache.ofbiz.testtools.TestRunContainer.start(TestRunContainer.java:90) > >> at > >> > org.apache.ofbiz.base.container.ContainerLoader.startLoadedContainers(ContainerLoader.java:153) > >> at > >> > org.apache.ofbiz.base.container.ContainerLoader.load(ContainerLoader.java:77) > >> at > >> > org.apache.ofbiz.base.start.StartupControlPanel.loadContainers(StartupControlPanel.java:146) > >> at > >> > org.apache.ofbiz.base.start.StartupControlPanel.start(StartupControlPanel.java:70) > >> at org.apache.ofbiz.base.start.Start.main(Start.java:89) > >> > > Met vriendelijke groet, > > > > Pierre Smits > > *Proud* *contributor** of* Apache OFBiz<https://ofbiz.apache.org/> > since > > 2008 (without privileges) > > Proud contributor to the ASF since 2006 > > > > *Apache Directory<https://directory.apache.org>, PMC Member* > > > > > > On Mon, Dec 13, 2021 at 10:28 AM Daniel Watford<d...@foomoo.co.uk> > wrote: > > > >> Hi Jacques, > >> > >> After running ./gradlew testIntegration I can confirm that I see the > test > >> failure for testInvoicePerShipmentSetFalse. > >> > >> The error was visible by viewing > >> $OFBIZ/runtime/logs/test-results/html/index.html in a browser and then > >> navigating to the invoicestests class. > >> > >> On Mon, 13 Dec 2021 at 08:28, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> > >> wrote: > >> > >>> Hi All, > >>> > >>> We have an issue withhttps://issues.apache.org/jira/browse/INFRA-22279 > >>> for tests on trunk and I need all your attention to help me fix it. > >>> > >>> The last successful trunk build on the old Buildbot (0.8) was <<*Oct. > >>> 18*>>: > >>> https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/ > >>> > >>> Gavin has worked since on INFRA-22279 but got stuck because of (I > >>> guess/hope only) testInvoicePerShipmentSetFalse error on trunk. > >>> > >>> The last time I locally tried the test was 09/Nov/21 19:31 > >>> < > >>> > >> > https://issues.apache.org/jira/browse/INFRA-22279?focusedCommentId=17441317&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17441317 > >>> Yesterday, I have tried locally to run the tests 3 times (I'm on > Windows > >>> and there are sometimes quirks with tests) and 3 times got this sole > >>> testInvoicePerShipmentSetFalse error. > >>> > >>> I have just checked the changes in accounting between 09/Nov/21 and > now. > >> I > >>> did not find any evidences related to testInvoicePerShipmentSetFalse. > >>> > >>> I'll continue on this today, if you know better please help. > >>> > >>> First I'd appreciate if you can confirm you also cross the > >>> testInvoicePerShipmentSetFalse error. > >>> > >>> TIA > >>> > >>> Jacques > >>> > >>> > >>> Le 31/08/2021 à 14:08, Jacques Le Roux a écrit : > >>>> Hi Gavin, > >>>> > >>>> Answering there > >>>> > >>>> Jacques > >>>> > >>>> Le 31/08/2021 à 11:32, Gavin McDonald a écrit : > >>>>> I have created a Jira ticket where we can liaise on the migration > >> which > >>> I > >>>>> would like to do ASAP. > >> > >> > >> -- > >> Daniel Watford > >>
