Hi Jacques, I haven't found a way to selectively inhibit the failure state of a gradle task.
However, I'm not sure we should take that approach otherwise we may find ourselves in a situation where issues related to checkstyle and codenarc are not addressed. [ Side note: In this particular case, the codenarc failure was caused by changes in ofbiz-plugins which are not built as part of the checking of a pull request. Codenarc issues will not be found in ofbiz-plugins until a new commit is pushed to ofbiz-framework trunk. Perhaps this is something we could think about. ] I have to confess to not checking Build Bot regularly. Instead I rely on the GitHub Actions builds since they are more visible to me. I imagine others are also failing to notice the status of the Build Bot builds and this is why these build failures are not getting addressed. To improve BuildBot visibility we could update the build status badges included in Readme.adoc. We currently include the badge for the framework build as: image:https://ci2.apache.org/badges/ofbizTrunkFramework.svg[link= https://ci2.apache.org/badges/ofbizTrunkFramework.svg] This should be change to link to BuildBot: image:https://ci2.apache.org/badges/ofbizTrunkFramework.svg[link= https://ci2.apache.org/#/builders/49] We could then add badges for the frameworkPlugins and RAT builds. Presumably the README.adoc would look something like: image:https://ci2.apache.org/badges/ofbizTrunkFrameworkPlugins.svg[link= https://ci2.apache.org/#/builders/46] image:https://ci2.apache.org/badges/ofbizTrunkFrameworkRat.svg[link= https://ci2.apache.org/#/builders/51] Perhaps there is a way to send an email notification to those who have pushed commits since the last successful build in the event of a new BuildBot build failure? Thanks, Dan. On Tue, 18 Apr 2023 at 13:29, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > Hi Team, > > Now that we have Codenarc used, we need to generate a report on our site > with BuildBot like we have: > https://nightlies.apache.org/ofbiz/trunk/checkstyle.html (also available > for next and stable). > This report allows everyone to see what the checkstyle problems are and to > fix them. > > In theory (much code violations) having a similar Codenarc report on site > would help us to fix the issue that we currently have at > https://ci2.apache.org/#/builders/46 reported below > > I launched the codenarcGroovyScripts Gradle task locally and got this > information at top of the report: > > Package Total Files Files with Violations Priority 1 > Priority 2 Priority 3 > All Packages 547 134 - 448 4396 > <Root> 62 46 - 269 2416 > > Fortunately the BB issue does not prevent the rest of the BB script to > complete (the BB "check" step is marked as "haltOnFailure=False") > So it's not a blocker and does not hide other possible issue happening > "below" but it sticks the build status to BUILD FAILED. > So if another issue happens "below"we will not be alerted (no status > change ever). > > Here is the part that fails on BB (note: as you can see Cobertura is not a > problem): > > > Task :checkstyleTest > The Cobertura XML file [null] is not accessible; skipping this rule > > Task :checkstyleMain > > Task :codenarcGroovyScripts > CodeNarc completed: (p1=0; p2=448; p3=4409) 66597ms > > > Task :codenarcGroovyScripts FAILED > FAILURE: Build failed with an exception. > > * What went wrong: > Execution failed for task ':codenarcGroovyScripts'. > > CodeNarc rule violations were found. See the report at: > > file:///home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/build/reports/codenarc/groovyScripts.html > > I'll create a Jira in order to generate a groovyScripts.html with BB > accessible on site. > But I'd like to know if it's possible to bypass the failed status. Either > by unlocking the rules or another mean? > > TIA > > Jacques > > Le 17/04/2023 à 11:26, build...@apache.org a écrit : > > Build status: BUILD FAILED: failed './gradlew --no-daemon ...' (failure) > './gradlew --no-daemon ...' (failure) > > Worker used: bb_worker4_ubuntu > > URL:https://ci2.apache.org/#builders/46/builds/507 > > Blamelist: Aditya Sharma<adityasha...@apache.org>, Benjamin Jugl< > benjamin.j...@ecomify.de>, Daniel Watford<d...@foomoo.co.uk>, Jacques Le > Roux<jacques.le.r...@les7arts.com>, Michael Brohl<michael.br...@ecomify.de>, > Nicolas Malin<nicolas.ma...@nereide.fr>, Pierre Smits< > pierre.sm...@gmail.com>, Pierre Smits<pierre.sm...@orrtiz.com>, > cshan-ecomify<117295991+cshan-ecom...@users.noreply.github.com> > > Build Text: failed './gradlew --no-daemon ...' (failure) './gradlew > --no-daemon ...' (failure) > > Status Detected: new failure > > Build Source Stamp: [branch trunk] > 145da8136056a76d4e5c8bb9e40ebe8a93de01fb > > > > > > Steps: > > > > worker_preparation: 0 > > > > git: 0 > > > > pullAllPluginsSource: 0 > > > > build: 0 > > > > check: 2 > > > > Copy checkstyle to destination directory structure: 0 > > > > generateReadmeFiles: 0 > > > > Copy readme: 0 > > > > generateOfbizDocumentation: 0 > > > > Copy OfbizDocumentation: 0 > > > > generateAllPluginsDocumentation: 0 > > > > Copy AllPluginsDocumentation: 0 > > > > javadoc: 0 > > > > Copy javadoc: 0 > > > > loadAll: 0 > > > > testIntegration: 2 > > > > clean things: 0 > > > > > > -- ASF Buildbot > > -- Daniel Watford
