Hi Jacques,

during a vendor import I noticed that there are several utul methods are being made private and therefore are not usable anymore.

Examples:

UtilDateTime#private static Timestamp getMonthStart(Timestamp stamp, int daysLater, int monthsLater, TimeZone timeZone, Locale locale) StringUtil#private static Map<String, String> strToMap(String str, String delim, boolean trim)

etc.

Can you explain why you reduced the scope?

Has there been any discussion to deprecate the public scope for those methods?

I'd suggest to revert those changes as it is not reasonable to make a small subset of those utility methods private.

Thanks,

Michael


Am 30.09.22 um 10:11 schrieb ASF subversion and git services (Jira):
     [ 
https://issues.apache.org/jira/browse/OFBIZ-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611416#comment-17611416
 ]

ASF subversion and git services commented on OFBIZ-10478:
---------------------------------------------------------

Commit a1093281a48ba42e7e48438db9eb6deac89e7627 in ofbiz-framework's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a1093281a4 ]

Fixed: Reducing scope of variables in org.apache.ofbiz.base package 
(OFBIZ-10478)

Reverts several public to private changes that should not have been
runtime exception: java.lang.NoSuchMethodException


Reducing scope of variables in org.apache.ofbiz.base package
------------------------------------------------------------

                 Key: OFBIZ-10478
                 URL: https://issues.apache.org/jira/browse/OFBIZ-10478
             Project: OFBiz
          Issue Type: Sub-task
          Components: base
    Affects Versions: Trunk, Upcoming Branch
            Reporter: Pradhan Yash Sharma
            Assignee: Jacques Le Roux
            Priority: Minor
             Fix For: Upcoming Branch

         Attachments: OFBIZ-10478.patch





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to