Big thanks for the work Nicolas ! Gil
Le vendredi 10 octobre 2025 à 11:55 +0200, Nicolas Malin a écrit : > Hello, > > I detected some blind error with codenarc 3.5.0 and groovy4. > > I fixed all after updated codenarc to version 3.6.0 and groovy4 > support[2], and remove the violation authorization for codenarc [1] > [3] . > > Now you can run `./gradlew check` on ofbiz-framework without > ofbiz-plugins :) and trust on it > > Nicolas > > [1] https://issues.apache.org/jira/browse/OFBIZ-13228 > [2] https://issues.apache.org/jira/browse/OFBIZ-13301 > [3] https://issues.apache.org/jira/browse/OFBIZ-13302 > > On 09/10/2025 17:55, Nicolas Malin wrote: > > I pushed it on trunk, > > > > If you detect any regression I'm available to fix it > > > > Nicolas > > > > On 04/08/2025 16:11, Nicolas Malin wrote: > > > Hello all, > > > > > > Recently I opened a pull request do remove all codenarc alert on > > > plugins [1]. > > > > > > It's a big code change because lot of code are deprecated, some > > > others migrate from bsh and someone didn't use. > > > > > > So this maelstrom of code didn't really help the check that not > > > regression has been introduce with code style fix. > > > > > > I propose to commit the code style to remove this dependency > > > between > > > plugin and framework, at this time the framework contains the > > > number > > > of plugin code style error, so when you run codenarc on framework > > > or > > > custom project, you need to load all OFBiz plugins (or update the > > > number on the framework). > > > > > > Or if someone have available time to help me for testing some > > > dark > > > area on plugins, I'll appreciate. > > > > > > If you have other suggest ? > > > > > > Nicolas > > > > > > [1] https://github.com/apache/ofbiz-plugins/pull/137 > >
